288509 - Dragging favicon from location bar into bookmark menu or personal toolbar's sub-folder creates double entry

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Christopher Vendemio]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050330 Firefox/1.0+ (bangbang023)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050330 Firefox/1.0+ (bangbang023)

If the user attempts to drag the favicon, from the address bar, and place it in
their bookmarks menu, the entry is listed twice. "Bookmark this page" works
properly and only lists the new bookmark once, when used. 

Reproducible: Always

Steps to Reproduce:
1.Browse to a page
2.Drag favicon to bookmark menu and drop it
3.

Actual Results:  
A double entry, of the bookmark, is listed

Expected Results:  
List the bookmark only once

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050331
Firefox/1.0+

Confirmed
->NEW

Any idea when this started ?

Comment 2

[Steve England [:stevee]]

In Gecko/20050314 Firefox/1.0+ dragging the bookmark from the address bar to the
bookmarks menu results in just 1 bookmark (expected behaviour)

Comment 3

[Steve England [:stevee]]

20050321 Firefox/1.0+ works as expected

Comment 4

[Steve England [:stevee]]

20050326 works as expected

Comment 5

[Steve England [:stevee]]

20050328 works as expected

Comment 6

[Steve England [:stevee]]

20050329 works as expected.

So it looks like it regressed between 20050329 & 20050330
Anyone got an idea of what checkin it was?

Comment 7

[Steve England [:stevee]]

as a complete stab in the dark, I would like to suggest that perhaps bug 255863
is the cause of this

Comment 8

[Peter van der Woude [:Peter6]]

normal in FF 20050329 08:15 PST build
double in FF 20050329 21:31 PST build
the checkin for that bug is in between the 2

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

duplicate of 288406?

Comment 10

[Steve England [:stevee]]

bug 288406 seems to say dragging the favicon causes a crash. In this case,
dragging the favicon in the URL bar to the Bookmarks > menu and dropping it
results in the bookmark being added twice.

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #9)
> duplicate of 288406?

Hmm, well, this is definitly not a crasher while bug 288406 is.

Comment 12

[Hermann Schwab]

(In reply to comment #11)
> (In reply to comment #9)
> > duplicate of 288406?
> 
> Hmm, well, this is definitly not a crasher while bug 288406 is.

May have the same cause, even Microsoft can get better ;-)
My bug was filed on Win98 and Win98SE, yours is filed on WinXP, that is the
WinNT/Win2k/WinXP Branch, technically rather different from Win9x.

timeframe for regression from comment 8:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-29+00%3A00&maxdate=2005-03-29+21%3A31&cvsroot=%2Fcvsroot

Comment 13

[Peter van der Woude [:Peter6]]

*** Bug 288978 has been marked as a duplicate of this bug. ***

Comment 14

[Peter van der Woude [:Peter6]]

kwd->regression
replaced "addressbar" by "locationbar" (the official name)

Comment 15

[Christopher Vendemio]

It seems to only happen, after further testing, when dropping into subfolders
and not into the main menu itself. 

Comment 16

[Peter van der Woude [:Peter6]]

No, I can drop into the main folder and the result is a double entry, every time
I tried

Comment 17

[Christopher Vendemio]

(In reply to comment #16)
> No, I can drop into the main folder and the result is a double entry, every time
> I tried

Really? That does not happen for me in my 4/4 build. 

Comment 18

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050404
Firefox/1.0+ 1446 PDT build

it does for me.
Even crashed the first time I tried.
After that just every time the double entry

Comment 19

[Jerry Baker]

-> trunk

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 290266 has been marked as a duplicate of this bug. ***

Comment 21

[Hermann Schwab]

see Bug 288406 Comment #20, there is a fix waiting to be tested.

Bug 288406 crash win98 when dragging bookmark proxy icon

comment 12 here tells about the similarities of these two bugs.	

Comment 22

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050418
Firefox/1.0+
Fixed by bug 288406 for me

Comment 23

[Joël Kuiper]

Agreed with comment #22 this bug is fixed by bug 288406 .
-> FIXED

Comment 24

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change