Closed Bug 288529 Opened 19 years ago Closed 19 years ago

Receipt notification message should not popup in spammail folder (Port Thunderbird fix)

Categories

(SeaMonkey :: MailNews: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

Attachments

(1 file, 1 obsolete file)

This was landed for Thunderbird (bug 218812 - rev 1.27) but not for mailnews,
also looking at including the landing for the try/catch around method call in
HandleMDNResponse (rev 1.29 & 1.30)
Status: NEW → ASSIGNED
Attached patch Port Patch v0.1 (obsolete) — Splinter Review
Attachment #179219 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 179219 [details] [diff] [review]
Port Patch v0.1

>+  var mimeHdr;
>+
>+  try {
>+    mimeHdr = aUrl.mimeHeaders;
>+  } catch (ex) { return 0;}
>+
This shouldn't be returning 0 here, because our version at least of
HandleMDNResponse does not return a value. Also the return should be on its own
line, the compact catch syntax only applies when you're only want to ignore
exceptions.
Attachment #179219 - Flags: review?(neil.parkwaycc.co.uk) → review+
Changes since v0.1
* Taken on board Neil's comments

Carried forward r=
Attachment #179219 - Attachment is obsolete: true
Attachment #179292 - Flags: superreview?(bienvenu)
Attachment #179292 - Flags: review+
Attachment #179292 - Flags: superreview?(bienvenu) → superreview+
Ian, would you like to do the same patch for thunderbird?
Comment on attachment 179292 [details] [diff] [review]
Revised Patch v0.1a (Checked in)

Checking in mailWindowOverlay.js;
/cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.js,v  <-- 
mailWindowOverlay.js
new revision: 1.216; previous revision: 1.215
done
Attachment #179292 - Attachment description: Revised Patch v0.1a → Revised Patch v0.1a (Checked in)
TB fix spun off into bug 288696
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: MailNews: Return Receipts → MailNews: Backend
QA Contact: grylchan → offline
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: