288637 - make of directory/c-sdk/ldap/include fails if --with-system-nspr is used

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

NSPR is available on the compiling system:
checking for nspr-config... /usr/bin/nspr-config
checking for NSPR - version >= 4.0.0 (skipping)... yes

gmake[4]: Entering directory
`/usr/src/packages/BUILD/mozilla/directory/c-sdk/ldap/include'
/usr/src/packages/BUILD/mozilla/dist/bin/nsinstall -D
/usr/src/packages/BUILD/mozilla/dist/public/ldap
/usr/bin/perl ./../build/replace.pl \
        LDAP_VENDOR_NAME="mozilla.org" \
                LDAP_VENDOR_VERSION="500" \
                < ldap-standard-tmpl.h >
/usr/src/packages/BUILD/mozilla/dist/public/ldap/ldap-standard.h
/usr/src/packages/BUILD/mozilla/dist/bin/nsinstall -D
/usr/src/packages/BUILD/mozilla/dist/public/ldap-private
/usr/src/packages/BUILD/mozilla/dist/bin/nsinstall -D
/usr/src/packages/BUILD/mozilla/dist/public/ldap-nspr
/usr/src/packages/BUILD/mozilla/dist/bin/nsinstall -R  -m 644 ./disptmpl.h
./lber.h ./ldap.h ./ldap-extension.h ./ldap-pla
tform.h ./ldap-to-be-deprecated.h ./ldap-deprecated.h ./ldap_ssl.h ./ldappr.h
./iutil.h ./srchpref.h /usr/src/packages/BUI
LD/mozilla/dist/public/ldap
/usr/src/packages/BUILD/mozilla/dist/bin/nsinstall -R  -m 644
./../libraries/libldap/ldap-int.h ./../libraries/liblber/lbe
r-int.h ./portable.h ./ldaprot.h ./ldaplog.h
/usr/src/packages/BUILD/mozilla/dist/public/ldap-private
rm -rf /usr/src/packages/BUILD/mozilla/dist/public/ldap-nspr/*
cp -r /usr/src/packages/BUILD/mozilla/dist/./include/nspr/*
/usr/src/packages/BUILD/mozilla/dist/public/ldap-nspr
cp: cannot stat `/usr/src/packages/BUILD/mozilla/dist/./include/nspr/*': No such
file or directory
gmake[4]: *** [export] Error 1

Comment 1

[cls]

Attachment: v1.0

I don't remember why LDAP was making a local copy of the NSPR header files but
they shouldn't be needed.

Comment 2

[Mark Smith [:mcs]]

Regarding comment #1, I don't remember why a local copy of the NSPR header files
was made.  Perhaps to make it easier to create a packaged LDAP C SDK?  But I
don't really see how making a copy helps there anyway.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 180395 [details] [diff] [review]
v1.0

I have a vague (possibly incorrect) recollection that I did things this way
because wtc asked me to.  Wan-Teh, is this something you remember and/or could
comment on?

If Wan-Teh has no objections, I'm ok with this change.

> 
> if test "$_WIN32_MSVC"; then
>-    _NO_NSPR=1
>+    _SYSETM_NSPR=
> fi

r- for now, because the above line isn't going to do the right thing.

Comment 4

[Wan-Teh Chang]

I don't remember asking LDAP C SDK maintainers to
make a local copy of NSPR header files, and I don't
know why it is useful.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

the patch doesn't work anymore if building without system NSPR for me

Comment 6

[cls]

Attachment: v1.1

Fixing typo.

Wolfgang:
My build using the in-tree NSPR worked fine.  What error are you seeing?

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

the buildsystem tries to call
/nsprpub/config/nspr-config --prefix=/usr/src/packages/BUILD/mozilla/dist
--cflags`  ldappr-dns.c

The path before nsprpub is missing from this call. This doesn't happen without
the patch. 

Comment 8

[Wan-Teh Chang]

Wolfgang,

I believe you applied the patch to configure.in but
did not regenerate configure.

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

oops, at least this is true :-(
I have bad experience with running autoconf on mozilla sources. I never had the
correct autoconf version to get a working config :-(

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 182100 [details] [diff] [review]
v1.1

r=dmose

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 182100 [details] [diff] [review]
v1.1

a=caillon for 1.8b3

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

looks like cls checked this in