HandleMDNResponse should not be returning 0

VERIFIED FIXED

Status

Thunderbird
Mail Window Front End
VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Bienvenu suggest that this should be patched on TB too.

Quoting from Neil's comments in bug 288529
  var mimeHdr;

  try {
    mimeHdr = aUrl.mimeHeaders;
  } catch (ex) { return 0;}

This shouldn't be returning 0 here, because our version at least of
HandleMDNResponse does not return a value. Also the return should be on its own
line, the compact catch syntax only applies when you're only want to ignore
exceptions.
(Assignee)

Comment 1

13 years ago
Created attachment 179323 [details] [diff] [review]
Patch v0.1 (Checked in)

This patch:
* Does return instead of return 0
* Does not use compact form of catch
* Does some whitespace tidy up round code being changed
Attachment #179323 - Flags: superreview?(bienvenu)
Attachment #179323 - Flags: review?(mscott)

Updated

13 years ago
Attachment #179323 - Flags: superreview?(bienvenu) → superreview+

Updated

13 years ago
Attachment #179323 - Flags: review?(mscott) → review+
(Assignee)

Comment 2

13 years ago
Comment on attachment 179323 [details] [diff] [review]
Patch v0.1 (Checked in)

Checking in mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <-- 
mailWindowOverlay.js
new revision: 1.86; previous revision: 1.85
done
Attachment #179323 - Attachment description: Patch v0.1 → Patch v0.1 (Checked in)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Verified FIXED via code inspection through LXR.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.