288696 - HandleMDNResponse should not be returning 0

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Ian Neal]

Bienvenu suggest that this should be patched on TB too.

Quoting from Neil's comments in bug 288529
  var mimeHdr;

  try {
    mimeHdr = aUrl.mimeHeaders;
  } catch (ex) { return 0;}

This shouldn't be returning 0 here, because our version at least of
HandleMDNResponse does not return a value. Also the return should be on its own
line, the compact catch syntax only applies when you're only want to ignore
exceptions.

Comment 1

[Ian Neal]

Attachment: Patch v0.1 (Checked in)

This patch:
* Does return instead of return 0
* Does not use compact form of catch
* Does some whitespace tidy up round code being changed

Comment 2

[Ian Neal]

Comment on attachment 179323 [details] [diff] [review]
Patch v0.1 (Checked in)

Checking in mailWindowOverlay.js;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v  <-- 
mailWindowOverlay.js
new revision: 1.86; previous revision: 1.85
done

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via code inspection through LXR.