Closed
Bug 288707
Opened 20 years ago
Closed 20 years ago
duplicated code between constructor and assignment operator of nsCSSValue
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
1.73 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
In bug 3247 comment 87, bzbarsky wrote: > > nsCSSValue::nsCSSValue(const nsCSSValue& aCopy) > > : mUnit(aCopy.mUnit) > > Want to factor out the shared code from here and operator= so we don't have to > keep changing both places every time? Separate bug fine for this if you want.
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8beta2
|
|
Assignee | |
Updated•20 years ago
|
Attachment #179431 -
Flags: superreview?(bzbarsky)
Attachment #179431 -
Flags: review?(bzbarsky)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 179431 [details] [diff] [review] patch r+sr=bzbarsky
Attachment #179431 -
Flags: superreview?(bzbarsky)
Attachment #179431 -
Flags: superreview+
Attachment #179431 -
Flags: review?(bzbarsky)
Attachment #179431 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Fix checked in to trunk, 2005-04-03 09:47 -0700.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•