288716 - JS error in msgMail3PaneWindow.js when switching layout with no message selected

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

Using Build ID 2005032605 on WinXP SP2
Steps to reproduce
1. Open mailnews
2. Either don't connect to mail server or make sure no message is selected
3. Switch from current layout to a different layout (in preferences)
4. Examine JS console

Expected results
1. No error messages to do with the switching of layout

Actual results
1. Error message along the lines of:
Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIMsgDBView.reloadMessage]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://messenger/content/msgMail3PaneWindow.js :: UpdateMailPaneConfig :: line
673"  data: no]
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 673

Comment 1

[Ian Neal]

Attachment: Patch v0.1

This patch:
* Adds to check to see if there is only a single message selected before
attempting to reload it

If there isn't a single message selected should a blank pane be displayed or
the mail start page?

Comment 2

[Ian Neal]

Attachment: Tweaked patch v0.1a

Changes since v0.1
* Additional check to make sure .selection exists before looking at count

Comment 3

[Ian Neal]

Attachment: Revised patch v0.1b

Changes since v0.1a
* Made use of GetNumSelectedMessages() as suggested by Neil

Comment 4

[Ian Neal]

This got checked in as part of bug 288366 and it was reviewd as part of patch
0.1e and 0.1f but I can reverse that part out and check it in once you have
reviewed this if you want.

Comment 5

[[e-mail]]

Comment on attachment 179525 [details] [diff] [review]
Revised patch v0.1b

Sorry, I thought I'd already reviewed this :-[

Comment 6

[[e-mail]]

Comment on attachment 179525 [details] [diff] [review]
Revised patch v0.1b

Wait a second, I'm blind

Comment 7

[[e-mail]]

It turns out that we have a convenience method gDBView.numSelected

Comment 8

[Ian Neal]

Fixed as part of bug 288366

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Followed steps to reproduce in comment 0 and couldn't reproduce in build
2005-05-08-05 on Windows XP Seamonkey trunk.

Verified FIXED.