Closed Bug 288736 Opened 20 years ago Closed 15 years ago

crash if I use gif (1px x 1px) for background:url

Categories

(Core Graveyard :: GFX: Win32, defect)

Product:
Core Graveyard
Component:
GFX: Win32
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: domen, Assigned: paper)

References

(
URL
)

Details

(Keywords: perf, testcase, Whiteboard: [sg:dos])

Attachments

(3 files, 1 obsolete file)

1x2 px image for testcase
43 bytes, image/gif
Details
Minimized testcase
166 bytes, text/html
Details
Handle padding for Progressive Double Blit tiling
7.41 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

In the page at http://dev2.domenca.si/prosport
line 28 (<td class="b01 cn01 x01">) class cn01 (.cn01 {background:#F1F1F2 url
(images/bg01.gif) repeat;}) couse firefox to crash down becouse the size of 
the image bg01.gif (1px x 1px).

Reproducible: Always

Steps to Reproduce:
1. Just open the page (dev2.domenca.si/prosport)
2.
3.

Actual Results:  
Firefox crash down

Expected Results:  
Work normal as in other browsers, ...

NO NOTE!
I got a hang rather than a crash, though maybe both happen. Happens in 1.7.5
Suite as well as Firefox 1.0.3, changing component to Core.
Assignee: firefox → nobody
Group: security
Status: UNCONFIRMED → NEW
Component: General → Layout
Ever confirmed: true
Keywords: hang
Product: Firefox → Core
QA Contact: general → layout
Whiteboard: [sg:dos]
Version: unspecified → 1.7 Branch
Is this an issue on trunk?
Keywords: testcase
Version: 1.7 Branch → Trunk
Attached file Testcase (obsolete) — 
This testcase hangs my computer every time. Its to nested divs using css
classes defined in the http://dev2.domenca.si/prosport/furniture.css

What is very odd is that I copied this furniture.css to my server
(http://www.jeria.net/mozilla/furniture.css) and linked to it, but then it
didn't hang. It does not also hang if I paste in the css in the html page. Only
hangs when you call the css from that server.
> Only hangs when you call the css from that server.

The CSS uses a relative URI to some background images.  Does making a copy of
the image locally as well (so that the CSS can link to it) make you crash
without relying on that server?
(In reply to comment #3)
> Created an attachment (id=183262) [edit]
> Testcase
> This testcase hangs my computer every time. Its to nested divs using css
> classes defined in the http://dev2.domenca.si/prosport/furniture.css
> What is very odd is that I copied this furniture.css to my server
> (http://www.jeria.net/mozilla/furniture.css) and linked to it, but then it
> didn't hang. It does not also hang if I paste in the css in the html page. 
Only
> hangs when you call the css from that server.

Even if you copy all files on your hard disk, .... , css will still hang 
firefox, ... 

        Attachment #183262 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        Minimized testcase
        — 
      

    


  
This testcase hangs Firefox trunk build (20050511)

Source code of testcase:
<html>
<head>
<title>bug 288736</title>
</head>

<body style="height:116px;
background:url(https://bugzilla.mozilla.org/attachment.cgi?id=183374);">
</body>
</html>

I tried replacing the image with a 1x1 non-transparent and a transparent image
with no luck. Firefox did not hang then.

    
    

    
  
Sounds like a Windows GFX issue... On Linux it takes a second or two to paint
the page, but there is no hang.
Assignee: nobody → win32
Component: Layout → GFX: Win32
QA Contact: layout → ian

    
    

    
  
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050509

Egads that's slow.  No crash, but a significant stall that would be horrible on
a slower machine.

I'll look into it

    
    

    
  


  
The GIF is 1x2, but the first frame is 1x1, so DrawTile was being called with a
1px Y-padding.	ProgressiveDoubleBlit doesn't handle padding, so we fell back
to the very very slow blit-one-by-one.

This patch adds padding handling to ProgressiveDoubleBlit.  Pretty small code
change, actually.
Assignee: win32 → paper
Status: NEW → ASSIGNED

        Attachment #183680 -
        Flags: review?(emaijala)

    
    

    
  
Comment on attachment 183680 [details] [diff] [review]
Handle padding for Progressive Double Blit tiling

Sorry for my slowliness. This patch doesn't apply anymore to the current
nsImageWin. Looks good to me anyway but would be good to have an updated patch
to test.

        Attachment #183680 -
        Flags: review?(emaijala)

    
    

    
  
I don't see hangs nor crashes. FF 1.5, FF 2.0, and trunk.  I do see poor perf with menus, loading new URLs, etc due to high cpu - cpu drops lower when the testcase tab is not the foreground tab

URL no longer available

URL: http://dev2.domenca.si/prosport → NA http://dev2.domenca.si/prosporta
Severity: critical → major
Keywords: hang → perf
Summary: crash if I use gif (1px x 1px) for background → crash if I use gif (1px x 1px) for background:url
Product: Core → Core Graveyard

    
    

    
  
Jose's testcase works fine for me in Firefox trunk on Vista.  The obsolete non-self-contained testcase also does not cause a crash or hang for me.

Paper and Ere, please file a new bug for that patch if you think it's still a good idea.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: