288797 - Alt-c on the search bar generates JS console error

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ian Neal]

This ports TB bug 239482 to mailnews and also fixes an issue with the Clear
button when nothing had focus prior to activating it.
Error in JS console is:
Error: focusedElement has no properties
Source File: chrome://messenger/content/searchBar.js
Line: 504

Comment 1

[Ian Neal]

Attachment: Patch v0.1

This patch:
* Adds Ctrl-k as key for focusing to search box
* Fixes problem on clearing search box

Comment 2

[R.K.Aa.]

conflicts with bug 66884?

Comment 3

[[e-mail]]

Comment on attachment 179422 [details] [diff] [review]
Patch v0.1

We already have Alt+S to focus the search bar. And we don't have to maintain
parity with the Firefox Google search bar. And we probably should find an
alternate element to focus before the clear button gets disabled.

Comment 4

[Ian Neal]

Attachment: Revised patch v0.1a

Changes since v0.1
* Dropped all changes apart from post clear button focus problem fix
* If gLastFocusedElement does not exist then focus on thread tree

Comment 5

[[e-mail]]

Comment on attachment 179461 [details] [diff] [review]
Revised patch v0.1a

>+  var focusedElement = gLastFocusedElement ? gLastFocusedElement : GetThreadTree();
Nit: Use || here (remember in JavaScript x || y is x ? x : y)

>+  if (focusedElement)
>+    focusedElement.focus();
We don't need this bit now surely?

r=me with these nits fixed.

Comment 6

[Ian Neal]

Attachment: Updated patch v0.1b (Checked in)

Changes since v0.1a
* Revised from ? to || as per Neil's request

Carried forward r=

Comment 7

[Ian Neal]

Comment on attachment 179505 [details] [diff] [review]
Updated patch v0.1b (Checked in)

Checking in searchBar.js;
/cvsroot/mozilla/mailnews/base/resources/content/searchBar.js,v  <-- 
searchBar.js
new revision: 1.40; previous revision: 1.39
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2006-01-06-09 of trunk SeaMonkey under Windows XP.