288831 - news.bbc.co.uk hangs firefox

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050403
Firefox/1.0+
Firefox.exe CREATION 03 April 2005, 03:44:36

1. Go to http://news.bbc.co.uk
2. Observe firefox hangs. Usually with 'newsimg.bbc.co.uk' in the status bar

Doesn't hang with official Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.8b2) Gecko/20050402 Firefox/1.0+ build

Comment 1

[Steve England [:stevee]]

kw > hang, regression

Comment 2

[Peter van der Woude [:Peter6]]

->Blocker
->mlk

Haven't tried with FF1.0.3 but I assume it's the same
reproducable on many sites including Gmail

regressed after bug 288818 landed

CC Brendan

Comment 3

[Peter van der Woude [:Peter6]]

?1.0.3 (it's cfmd on aviary too)
?1.1

Comment 4

[Peter van der Woude [:Peter6]]

Gmail repro:
1.open FF
2.go to gmail inbox
3.label a large file and press archive
4.freeze

Comment 5

[Martijn Wargers (dead)]

I've backed out the patch from bug 288137. After that, I don't see the bug
anymore in my debug build. 

Comment 6

[Peter van der Woude [:Peter6]]

(In reply to comment #3)
> ?1.0.3 (it's cfmd on aviary too)
> ?1.1

(In reply to comment #3)
>I've backed out the patch from bug 288137. After that, I don't see the bug
>anymore in my debug build.

Bah, I misread a comment, does NOT happen on Aviary.
bug 288137 was not checked in on Aviary either
+1.0.3 can be remove (and +1.7.7 aswell I suppose)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The gmail hang is definitely bug 288137.  Is the news.bbc.co.uk hang as well?

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(FWIW, I couldn't reproduce the news.bbc.co.uk hang, but I could repro the gmail
hang, and it was in the function smontagu modified.)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(The function in nsHTMLContentSerializer, that is.)

Comment 10

[Simon Montagu :smontagu]

Are you all testing on depend builds? I discovered testing bug 210501 that
unicharutil still has dependency issues.

Comment 11

[Peter van der Woude [:Peter6]]

(In reply to comment #8)
> (FWIW, I couldn't reproduce the news.bbc.co.uk hang, but I could repro the gmail

I have Adblock disabled
Cookies blocked
popups blocked

Opening http://news.bbc.co.uk freezes FF before rendering anything

Comment 12

[Simon Montagu :smontagu]

I think I have a handle on this.

Comment 13

[Simon Montagu :smontagu]

Attachment: patch

Doh! In some code paths I never set lengthReplaced so advanceLength wasn't
getting incremented.

Comment 14

[Simon Montagu :smontagu]

Checked in

Comment 15

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050403
Firefox/1.0+ 12:30 PDT build

Gmail and BCC both work again with no extra mem usage

->Verified

Thanks for the quick fix

Comment 16

[Simon Fraser [no longer active]]

*** Bug 288905 has been marked as a duplicate of this bug. ***