288891 - ICAL_STATUS_ constants are undefined, mouseover Status: field is blank

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: trunk

ICAL_STATUS_ constants are undefined, mouseover Status: field is blank

Reproducible: Always

Steps to Reproduce:
1. Mouseover event or task.


Actual Results:  
Status field is blank.

JavaScript console shows:

Warning: reference to undefined property iCalToDo.ICAL_STATUS_NEEDSACTION
Source File: chrome://calendar/content/mouseoverPreviews.js
Line: 274

and several more.

Expected Results:  
mouseover tooltip shows status.

Workaround: edit event or task to view status.

Comment 1

[gekacheka]

Attachment: mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings

(patch -l -p 2 -i file.patch)

The ICAL_STATUS_... constants are no longer available to specify status values.

The current values are literal RFC2445sec4.8.1.11 strings, so this patch just
inserts the literal strings into the code just like in eventDialog.js.	In
addition to the RFC2445sec4.8.1.11 strings, eventDialog.js also uses "None"
(capitalized, not allcaps) as a value, so that is used here as well.

(It would be nice to define these as constants somewhere, so there would be 
better checking against misspellings, mishyphenization, or miscapitalization. 
But I'm not sure where would be a good place.  It might be hard to refer to
such external constants in all contexts where they are used: eventDialog.xul,
eventDialog.js, and mouseoverPreviews.js.)

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 179524 [details] [diff] [review]
mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings

shaver knows these constants...

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 179524 [details] [diff] [review]
mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings

Why is "None" not "NONE"?  If it works, this is an improvement for sure, but
I'd rather see that be capitalized.

Also, we should remove the constants if they're no longer used.

Can you pop up another patch that does both those things?  Thanks.

Comment 4

[gekacheka]

Attachment: mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings + "NONE"

(patch -l -p 2 -i file.patch)

Fix patch to use "NONE" instead of "None".

(The previous patch used "None" because that was the value used in
eventDialog.js)

The event.ICAL_STATUS_ javascript constants were defined in libxpical which is
no longer used so there is no point in removing them.  
http://lxr.mozilla.org/seamonkey/source/calendar/libxpical/oeIICal.idl#85

(I guess the new interfaces do not have these constants because the new values
are strings and idl interfaces cannot define cross platform string constants.)
http://www.mozilla.org/scriptable/xpidl/idl-authors-guide/rules.html#enum-and-const

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 180181 [details] [diff] [review]
mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings + "NONE"

You should really ask review from someone...

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180181 [details] [diff] [review]
mouseoverPreviews.js: replace ICAL_STATUS constants with RFC2445sec4.8.1.11 strings + "NONE"

Sweet, thanks. r=shaver

(We should cvsremove libxpidl some time.)

Comment 7

[Mike Shaver (:shaver emeritus)]

Committed the latest patch.  Thanks!