288921 - [FIX]Media (and XUL) documents have no content-disposition

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

The problem is that content-disposition is only set in nsContentSink on the
document.  It should probably happen in RetrieveRelevantHeaders.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To clarify, the steps are:

1) Load http://inconstruction.kairo.at/?d=g&p=2289&f[m]=thumb
2) hit Ctrl-S

The suggested filename shouldn't be the hostname.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

This patch just moves processing of all headers except "link" from the sink
into the document, since the sink itself doesn't really need to deal with them.
 It also moves processing of the "refresh" header for normal loads out of
docshell and into the document so that the header won't be processed twice if
it's an actual HTTP header (the document needs to process it for the case when
it's a <meta> tag).  I've tested that refresh still works, both as HTTP and
meta tag.

The end result is that documents that don't use nsContentSink (XUL and media
documents) still get the relevant headers.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 179590 [details] [diff] [review]
Proposed patch

r+sr=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.