288954 - nsID claims it is frozen, but exports C++ symbols

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[Benjamin Smedberg]

nsID claims it is frozen. This is certainly correct for the struct layout, but
I'm not sure whether it means we nsID::Parse and nsID::ToString, which are
dllexports. If we *did* freeze them, we need to expose them from xpcom.dll and
not just xpcom_core.dll. In any case, I would like to make both of these frozen
C exports NS_ParseID and NS_IDToString (and add inline wrappers for existing
callers).

Comment 1

[Benjamin Smedberg]

Marking blocking 1.8 at least until we the frozen-API issues are sorted out.

Comment 2

[Darin Fisher]

No, nsID::Parse and nsID::ToString are not frozen.  The exports have mangled
names, so they are not in any way ready to be frozen.  I agree, that we should
expose those APIs.

Comment 3

[Benjamin Smedberg]

Attachment: Move nsID symbols to the glue, rev. 1

This simply moves the impl to the glue, instead of exposing it via a frozen
export which I believe is unnecesary. This also needs cvsmoves which I will
attach separately.

Comment 4

[Darin Fisher]

Comment on attachment 190145 [details] [diff] [review]
Move nsID symbols to the glue, rev. 1

nice!  r=darin

Comment 5

[Benjamin Smedberg]

Attachment: Move nsID.h/cpp to xpcom/glue, rev. 1

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 190145 [details] [diff] [review]
Move nsID symbols to the glue, rev. 1

a=shaver

Comment 7

[Benjamin Smedberg]

Justdave/shaver, can one of you do the cvsmoves?

Comment 8

[Benjamin Smedberg]

Reassigning to Dave for cvsmoves, please assign back to me once those are complete.

Comment 9

[Dave Miller [:justdave]]

cvsmove completed, give it about 5 min for cvs-mirror to pick it up, then please
verify.

Comment 10

[Benjamin Smedberg]

Fixed on trunk for 1.8b4. Thank you Dave.