28896 - Support file version tracking and reg leaves in related APIs.

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[David Epstein]

builds 2000-02-22. all platforms. tried with old and new reg files.
1. Go to http://jimbob/trigger2.html
2. Select a test case. i.e. a_addtestfile, a_adddelfile, a_adddirectory_4, 
a_addsubcomp_full_iver_ver, a_execute, etc.
3. Trigger. OK.
4. Using BiggerRegToy, open reg file in 4.7 (using "Open Registry File" 
pathway).
5. Traverse reg tree with child nodes.
Result: The package gets registered, but not the leaves. So a file or folder, 
for example, will not have a registry entry.
This affects things like file or directory installation which depend upon the 
force parameter (i.e. it will install when force = false and version string is 
smaller, since the previous version is not registered).

Comment 1

[David Epstein]

also affects GetVersion, CompareVersion, etc.

Comment 2

[Daniel Veditz [:dveditz]]

This was necessary trimming due to Mac performance. We store only the package 
information, not the individual file information.

Dougt has a proposal that we have a way to store specific files, Samir 
suggested we store directory information for addDirectory() calls (but not the 
subfiles added). Discussion will take place in the newsgroup and future bugs 
opened once we know which direction we're going. But this will not change for 
beta, the performance hit the old way was just too great.

Comment 3

[Cathleen]

per David's comment in the email (below), I think we should leave this bug open 
as a tracking bug for getting those API with regName parameters working again.

Changing summary from
" Changes to registry affecting addFile & addDir (force mode) & version object 
tests." 
to
" Need to support file version tracking "

-----------------------------------------------------------------

> This bug wasn't written because files & directories are no longer registered, 
> but because of the APIs that are broken because of the reg changes. My 
> thinking was that this would be a tracking bug for all the APIs which have a 
> regName parameter (forms of addFile, addDir, compareversion, patch, ...) 
> rather than submit a bug for each one.
> 
> If it's more convenient to write a bug for each one, we can do that. I just 
> thought it would be easier this way. And realizing that this won't be touched 
> for this beta.
>
> - david

Comment 4

[Cathleen]

reopen bug, and set target milestone to M15

Comment 5

[Cathleen]

reassign to dveditz.
bug meeting 3/20

Comment 6

[David Epstein]

getComponentFolder also affected by this. Go to http://jimbob/trigger3.html. Try 
a_getcomponentfolder and a_getcomponentfolder_2 from acceptance case menu. Both 
return "null" for directory pathway:

-------------------------------------------------------------------------------
http://jimbob/jars/a_getcomponentfolder.xpi  --  05/01/2000 16:25:50
-------------------------------------------------------------------------------

     Acceptance: a_getcomponentfolder
     --------------------------------

     [1/1]	Installing: C:\Program Files\Netscape\Netscape 
6\a_getcomponentfolder.txt

     Install completed successfully
     ** GetComponentFolder should return path to Program directory: null
     Finished Installation  05/01/2000 16:25:50

-------------------------------------------------------------------------------
http://jimbob/jars/a_getcomponentfolder_2.xpi  --  05/01/2000 16:25:55
-------------------------------------------------------------------------------

     Acceptance: a_getcomponentfolder_2
     ----------------------------------

     [1/1]	Installing: C:\Program Files\Netscape\Netscape 
6\a_getcomponentfolder_2.txt

     Install completed successfully
     ** GetComponentFolder should return path to Program with 
a_getcompfolder_2_subdir: null
     Finished Installation  05/01/2000 16:25:55

Comment 7

[Cathleen]

must fix in PR2

Comment 8

[Cathleen]

*** Bug 28897 has been marked as a duplicate of this bug. ***

Comment 9

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 10

[David Epstein]

Another API this affects is deleteRegisteredFile(). Script a_delregfile.xpi 
(after running a_adddelregfile.xpi) cancels and returns unidentified value = 3.

Comment 11

[Daniel Veditz [:dveditz]]

Could you please write up the delete registered file as a separate bug? Even 
once this one is fixed it sounds like calling deleteregisteredfile on a bogus 
regname will give the bogus error 3 -- this needs to be one of the 
approved/documented error codes instead.

Comment 12

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 13

[Blake Ross]

So, what's the deal with this?  ETA was 7/15...

Comment 14

[Daniel Veditz [:dveditz]]

Checking our current install scripts none depend on this functionality. I think 
we can live with it post PR2

Comment 15

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2.  Adding "nsbeta3" keyword 
for consideration of a fix for that milestone. 

Comment 16

[Daniel Veditz [:dveditz]]

We can ship without this, it's not causing instability. nsbeta3-

Comment 17

[David Epstein]

Changed summary to reflect leaf-only issue. APIs accepting reg keys (other than 
addFile and addDir) are getVersion, compareVersion, getComponentFolder, and 
deleteRegisteredFile. Spun off other bugs dealing with reg nodes not working in 
APIs (53845 - getversion(), 54086 - delRegFile, 54096 - getCompFile). 

Comment 18

[Daniel Veditz [:dveditz]]

Resetting target field for missed milestones

Comment 19

[Daniel Veditz [:dveditz]]

The SmartUpdate site needs this to be able to tell when things have been 
uninstalled.

Comment 20

[Daniel Veditz [:dveditz]]

Moz 0.8 tasks 

Comment 21

[selmer (gone)]

We're past time to cut these low priority bugs from mozilla0.8.  Please update
these bugs today. 

Comment 22

[Daniel Veditz [:dveditz]]

Attachment: patch for this bug, plus some memory cleanup and pruning of dead code

Comment 23

[Sean Su]

r=ssu

Comment 24

[Scott MacGregor]

sr=mscott

Comment 25

[Daniel Veditz [:dveditz]]

fix checked-in 3/13/2001

Comment 26

[Daniel Veditz [:dveditz]]

fix checked-in 3/13/2001

Comment 27

[David Epstein]

changed QA owner to jimmylee.

Comment 28

[Jimmy Lee]

Build: 2001-03-15-15-Mtrunk(WIN), 2001-03-15-09-trunk(MAC), 
2001-03-15-08-Mtrunk(LINUX)

Looks fine on all platforms.  Marking Verified.