289002 - cannot set/clear requests with requestee

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

when I try to clear requests (some having a requestee), I get the following error:

URL: http://localhost/cvsbugzilla/process_bug.cgi

undef error - Can't use string ("") as an ARRAY ref while "strict refs" in use
at Bugzilla/User.pm line 1021.

Comment 1

[Frédéric Buclin]

OK, please read line 1017 above (I had another patch applied).

    # No mail if there are no events
    return 0 if !scalar(@$events);

This comes from wants_mail().

Comment 2

[Gervase Markham [:gerv]]

I can't figure out what's going on here. The calls to wants_mail in Flag.pm all
pass array references, yet Perl is complaining that it's a scalar...

Gerv

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Perhaps it's these:

/webtools/bugzilla/template/en/default/request/email.txt.tmpl, line 32 -- IF
flag.requestee.wants_mail(constants.EVT_FLAG_REQUESTED) %]
/webtools/bugzilla/template/en/default/request/email.txt.tmpl, line 37 -- IF
flag.setter.wants_mail(constants.EVT_REQUESTED_FLAG) %]

Comment 4

[Teemu Mannermaa (:wicked)]

Attachment: Correct constant calls in template, V1

Myk was on right track. Those constants seemed to be passed in wrong format for
the wants_mail sub. I wrapped them inside [] which fixed the problem.

Comment 5

[Frédéric Buclin]

Comment on attachment 180136 [details] [diff] [review]
Correct constant calls in template, V1

obviously correct. Tested, works!

r=LpSolit

Nice catch! Thanks to myk and wicked! :)

Comment 6

[Frédéric Buclin]

Checking in template/en/default/request/email.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/email.txt.tmpl,v
 <--  email.txt.tmpl
new revision: 1.8; previous revision: 1.7
done

Comment 7

[Gervase Markham [:gerv]]

Thanks, guys :-)

Gerv