289049 - ShowMessage called at wrong time

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[lvcipriani]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2


In the file mozilla/toolkit/mozapps/installer/windows/wizard/setup/extra.c
there are two extra semicolons; one at line 2446:

  if(*sgProduct.greCleanupOrphansMessage != '\0');
    ShowMessage(sgProduct.greCleanupOrphansMessage, TRUE);

should be:

  if(*sgProduct.greCleanupOrphansMessage != '\0')
    ShowMessage(sgProduct.greCleanupOrphansMessage, TRUE);

----------------------------------------------------------------------

and another one at line 2592:

  if(*sgProduct.greCleanupOrphansMessage != '\0');
    ShowMessage(sgProduct.greCleanupOrphansMessage, FALSE);

should be:

  if(*sgProduct.greCleanupOrphansMessage != '\0')
    ShowMessage(sgProduct.greCleanupOrphansMessage, FALSE);


Reproducible: Always

Steps to Reproduce:
1. see source
2.
3.



Expected Results:  
see Details

Comment 1

[Charles Fenwick]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 179646 [details] [diff] [review]
patch

r=me

Comment 3

[Benjamin Smedberg]

Fixed on trunk.