Closed
Bug 289050
Opened 20 years ago
Closed 20 years ago
mPosition incremented incorrectly
Categories
(Core Graveyard :: SQL, defect)
Core Graveyard
SQL
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: lvcipriani, Assigned: lvcipriani)
Details
Attachments
(1 file)
|
881 bytes,
patch
|
janv
:
review+
bzbarsky
:
superreview+
shaver
:
approval1.8b2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
In the file mozilla/extensions/sql/base/src/mozSqlResult.cpp at line 2221 there
is an extra semicolon:
if (NS_SUCCEEDED(rv));
mPosition += aCount;
should be:
if (NS_SUCCEEDED(rv))
mPosition += aCount;
Reproducible: Always
|
||
Updated•20 years ago
|
Assignee: general → jan
Component: General → SQL
Product: Mozilla Application Suite → Core
QA Contact: general → irixman+bugzilla
Version: unspecified → Trunk
|
|
||
Comment 1•20 years ago
|
||
Attachment #183513 -
Flags: review?(jan)
|
|
||
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 2•20 years ago
|
||
Comment on attachment 183513 [details] [diff] [review] Reporter's patch thanks for the fix
Attachment #183513 -
Flags: review?(jan) → review+
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 183513 [details] [diff] [review] Reporter's patch Requesting trunk approval
Attachment #183513 -
Flags: superreview+
Attachment #183513 -
Flags: approval1.8b2?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 183513 [details] [diff] [review] Reporter's patch a=shaver (npotb anyway).
Attachment #183513 -
Flags: approval1.8b2? → approval1.8b2+
|
|
||
Updated•20 years ago
|
Assignee: jan → lvcipriani
|
|
||
Comment 5•20 years ago
|
||
Fix checked in for 1.8b2
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•