289053 - ###!!! ASSERTION: |First()| called on an empty string: 'mLength > 0', file r:\mozilla\all-i686-pc-cygwin\dist\include\string\nsTSubstring.h, line 201

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[timeless]

###!!! ASSERTION: |First()| called on an empty string: 'mLength > 0', file
r:\mozilla\all-i686-pc-cygwin\dist\include\string\nsTSubstring.h, line 201

 	xpcom_core.dll!nsDebug::Assertion(const char * aStr=0x02554f70, const char *
aExpr=0x02554f94, const char * aFile=0x02545040, int aLine=201)  Line 109	C++
 	gklayout.dll!nsSubstring::First()  Line 201 + 0x23	C++
 	gklayout.dll!nsHTMLFontElement::ParseAttribute(nsIAtom *
aAttribute=0x003ff330, const nsAString & aValue={...}, nsAttrValue &
aResult={...})  Line 145 + 0xb	C++
 	gklayout.dll!nsGenericHTMLElement::SetAttr(int aNamespaceID=0, nsIAtom *
aAttribute=0x003ff330, nsIAtom * aPrefix=0x00000000, const nsAString &
aValue={...}, unsigned int aLineNo=0, int aNotify=0)  Line 1703 + 0x20	C++
 	gklayout.dll!nsGenericHTMLElement::SetAttr(int aNamespaceID=0, nsIAtom *
aAttribute=0x003ff330, nsIAtom * aPrefix=0x00000000, const nsAString &
aValue={...}, int aNotify=0)  Line 1660	C++
 	gklayout.dll!nsIContent::SetAttr(int aNameSpaceID=0, nsIAtom *
aName=0x003ff330, const nsAString & aValue={...}, int aNotify=0)  Line 261	C++
 	gklayout.dll!HTMLContentSink::AddAttributes(const nsIParserNode & aNode={...},
nsIContent * aContent=0x036b1218, int aNotify=0, int aCheckIfPresent=0)  Line
846	C++
 	gklayout.dll!SinkContext::OpenContainer(const nsIParserNode & aNode={...}) 
Line 1272 + 0x16	C++
 	gklayout.dll!HTMLContentSink::OpenContainer(const nsIParserNode & aNode={...})
 Line 3029 + 0x12	C++
 	gkparser.dll!CNavDTD::OpenContainer(const nsCParserNode * aNode=0x038777f8,
nsHTMLTag aTag=eHTMLTag_font, int aClosedByStartTag=1, nsEntryStack *
aStyleStack=0x00000000)  Line 3279 + 0x1f	C++
 	gkparser.dll!CNavDTD::HandleDefaultStartToken(CToken * aToken=0x049e9860,
nsHTMLTag aChildTag=eHTMLTag_font, nsCParserNode * aNode=0x038777f8)  Line
1288 + 0x14	C++
 	gkparser.dll!CNavDTD::HandleStartToken(CToken * aToken=0x049e9860)  Line
1654 + 0x14	C++
 	gkparser.dll!CNavDTD::HandleToken(CToken * aToken=0x049e9860, nsIParser *
aParser=0x0467d498)  Line 910 + 0xc	C++
 	gkparser.dll!CNavDTD::BuildModel(nsIParser * aParser=0x0467d498, nsITokenizer
* aTokenizer=0x0443c820, nsITokenObserver * anObserver=0x00000000,
nsIContentSink * aSink=0x0527ca40)  Line 461 + 0x14	C++
 	gkparser.dll!nsParser::BuildModel()  Line 2069 + 0x22	C++
 	gkparser.dll!nsParser::ResumeParse(int allowIteration=1, int aIsFinalChunk=0,
int aCanInterrupt=1)  Line 1936 + 0xc	C++
 	gkparser.dll!nsParser::OnDataAvailable(nsIRequest * request=0x046dea30,
nsISupports * aContext=0x00000000, nsIInputStream * pIStream=0x035aa3a8,
unsigned int sourceOffset=0, unsigned int aLength=2508)  Line 2616 + 0x15	C++
 	docshell.dll!nsDocumentOpenInfo::OnDataAvailable(nsIRequest *
request=0x046dea30, nsISupports * aCtxt=0x00000000, nsIInputStream *
inStr=0x035aa3a8, unsigned int sourceOffset=0, unsigned int count=2508)  Line
349 + 0x2e	C++
 	necko.dll!nsStreamListenerTee::OnDataAvailable(nsIRequest *
request=0x046dea30, nsISupports * context=0x00000000, nsIInputStream *
input=0x0459b5c8, unsigned int offset=0, unsigned int count=2508)  Line 97 +
0x33	C++
 	necko.dll!nsHttpChannel::OnDataAvailable(nsIRequest * request=0x0459b738,
nsISupports * ctxt=0x00000000, nsIInputStream * input=0x0459b5c8, unsigned int
offset=0, unsigned int count=2508)  Line 3920 + 0x44	C++
 	necko.dll!nsInputStreamPump::OnStateTransfer()  Line 437 + 0x46	C++
 	necko.dll!nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream *
stream=0x0459b5c8)  Line 340 + 0xb	C++
 	xpcom_core.dll!nsInputStreamReadyEvent::EventHandler(PLEvent *
plevent=0x04e8e0dc)  Line 120	C++
 	xpcom_core.dll!PL_HandleEvent(PLEvent * self=0x04e8e0dc)  Line 698 + 0xa	C
 	xpcom_core.dll!PL_ProcessPendingEvents(PLEventQueue * self=0x01143078)  Line
633 + 0x9	C
 	xpcom_core.dll!_md_TimerProc(HWND__ * hwnd=0x000e12b6, unsigned int uMsg=275,
unsigned int idEvent=0, unsigned long dwTime=2095807203)  Line 1034 + 0x9	C
 	user32.dll!_InternalCallWinProc@20()  + 0x28	
 	user32.dll!_UserCallWinProc@24()  + 0xa1	
 	user32.dll!_DispatchMessageWorker@8()  + 0xcc6	
 	user32.dll!_DispatchMessageA@4()  + 0xf	
 	mfc71d.dll!AfxInternalPumpMessage()  Line 188	C++
 	mfc71d.dll!CWinThread::PumpMessage()  Line 916	C++
 	mfc71d.dll!CWinThread::Run()  Line 637 + 0xb	C++
 	mfc71d.dll!CWinApp::Run()  Line 701	C++
 	mfc71d.dll!AfxWinMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__ *
hPrevInstance=0x00000000, char * lpCmdLine=0x00142384, int nCmdShow=10)  Line
49 + 0xb	C++
 	mfcembed.exe!WinMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__ *
hPrevInstance=0x00000000, char * lpCmdLine=0x00142384, int nCmdShow=10)  Line 25	C++
 	mfcembed.exe!WinMainCRTStartup()  Line 390 + 0x39	C
 	kernel32.dll!_BaseProcessStart@4()  + 0x23

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

I also made us at least properly render ridiculous relative fontsizes properly.
We'll still end up treating "+20" as "20", but I think we can deal with that.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in, thanks for the quick review