Closed Bug 289059 Opened 19 years ago Closed 19 years ago

AIX GTK2 build fails to link after checkin for Bug 280725

Categories

(Firefox Build System :: General, defect)

Other
AIX
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pkwarren, Assigned: pkwarren)

Details

Attachments

(1 file)

The checkin for Bug 280725 added a dependency on the X11 libraries on the
toolkit/components/remote library. Since -lX11 isn't included in the pkg-config
output for gtk2 on AIX, it is necessary to explicitly link against X11 libraries
to resolve all of the necessary symbols.

This is similar to Bug 236836, which was fixed for mozilla-bin.
Attached patch Patch v1Splinter Review
This fixes the error by adding an explicit dependency on the X11 libraries when
linking this shared library.
Assignee: nobody → pkwarren
Status: NEW → ASSIGNED
Attachment #179657 - Flags: review?(benjamin)
Comment on attachment 179657 [details] [diff] [review]
Patch v1

Urgh. Oh well.
Attachment #179657 - Flags: review?(benjamin) → review+
Attachment #179657 - Flags: superreview?(bryner)
Attachment #179657 - Flags: superreview?(bryner) → superreview?(tor)
Attachment #179657 - Flags: superreview?(tor) → superreview+
Fixed.

Checking in Makefile.in;
/cvsroot/mozilla/toolkit/components/remote/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
hrm, that's not in autoconf.mk.in, although configure.in does AC_SUBST(MOZ_X11)...
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: