nsPluginInstallerWizard.prototype.loadURL should use the webpage to open a new window, not chrome

RESOLVED INVALID

Status

RESOLVED INVALID
14 years ago
2 years ago

People

(Reporter: doronr, Assigned: doronr)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
This is the real fix for security bug 288556.

window.opener points to chrome, we should rather use an html webpage.
(Assignee)

Comment 1

14 years ago
Created attachment 181796 [details] [diff] [review]
patch
Attachment #181796 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

14 years ago
Comment on attachment 181796 [details] [diff] [review]
patch

window.opener.content.open perhaps?
(Assignee)

Comment 3

14 years ago
Is there any advantage to useing .content?
Product: Firefox → Toolkit

Comment 4

4 years ago
(In reply to Doron Rosenberg (IBM) from comment #3)
> Is there any advantage to useing .content?
Flags: needinfo?(neil)

Comment 5

4 years ago
.content is a convenient shorthand for .getBrowser().mCurrentBrowser.contentWindow but has the other advantage in that it's more generic code (e.g. doesn't rely on an implementation detail of tabbrowser, so might work in Thunderbird too).
Flags: needinfo?(neil)
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
Product: Toolkit → Toolkit Graveyard

Comment 6

2 years ago
Comment on attachment 181796 [details] [diff] [review]
patch

cancelling review on dead bug
Attachment #181796 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.