289178 - Move show_punycode pref into nsStandardURL

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Darin Fisher]

Move show_punycode pref into nsStandardURL

Per https://bugzilla.mozilla.org/show_bug.cgi?id=283992#c14, it would be better
to move pref checking into nsStandardURL so that the core IDN conversion
routines can still be used by other consumers.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

+    static nsIIDNService               *gIDN;

shouldn't that be sIDN, as it's a class static, not a global? (and the other
static members too...)

Comment 3

[Darin Fisher]

(In reply to comment #2)
> +    static nsIIDNService               *gIDN;
> 
> shouldn't that be sIDN, as it's a class static, not a global? (and the other
> static members too...)

"pick a style, any style, but be consistent"  ... i chose to be consistent with
the existing code rather than bloat the patch.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 180014 [details] [diff] [review]
v1 patch

sr=dbaron (I even went back and compared to bug 282270)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 180014 [details] [diff] [review]
v1 patch

netwerk/base/src/nsStandardURL.cpp
	     mHostA = ToNewCString(result);

hm... I wonder why this is not an nsCString or something...

Comment 6

[Darin Fisher]

> netwerk/base/src/nsStandardURL.cpp
> 	     mHostA = ToNewCString(result);
> 
> hm... I wonder why this is not an nsCString or something...

Because we almost never allocate it.  I chose to reserve 4 bytes instead of 16
for this member variable.  I suppose now that nsCString supports buffer sharing,
that we could benefit from allocating a new nsCString object.  Hmm :-/

Comment 7

[Darin Fisher]

Comment on attachment 180014 [details] [diff] [review]
v1 patch

This could slip until 1.8b3 if we are getting tight with approvals.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 180014 [details] [diff] [review]
v1 patch

a=asa

Comment 9

[Darin Fisher]

fixed-on-trunk