289197 - offline settings just opens new options dialogue

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050326 Firefox/1.0+ (MOOX M2)
Build Identifier: Thunderbird version 1.0+ (20050404)

After new options dialogue is added, Offline settings menu command only opens it.

Reproducible: Always

Steps to Reproduce:
1. Click File>Offline>Offline Settings...


Actual Results:  
Options dialogue is opened, and it is opened with last active tab activated

Expected Results:  
Offline settings dialogue should be launched.

Comment 1

[Mike Cowperthwaite]

This is working as expected as of builds dated 0406 -- probably due to the 
checkin for bug 289210.

Comment 2

[Ivan Ičin]

Maybe I didn't describe the bug well, but I can still reproduce it on the build
you are talking about (0406) with clean profile.

Are you sure that you don't see any problems with this:

1. Click Tools/Options, select General tab
2. Click File/Offline/Offline settings...

I get Options dialogu with General tab activated.

Comment 3

[Mike Cowperthwaite]

(In reply to comment #2)
> 1. Click Tools/Options, select General tab

1.5. Close Options dialog

> 2. Click File/Offline/Offline settings...
> 
> I get Options dialogu with General tab activated.


OK, yes, I see that.  And it *should* be opening the same dialog, but with the 
new Offline Settings page selected.

Comment 4

[sairuh (rarely reading bugmail)]

I also see this with recent trunk tbird builds on Mac.

Comment 5

[Scott MacGregor]

Attachment: the fix

1) Supports the ability to pass in an options panel ID into openOptionsDialog
which will open the options dialog (or re-focus it) and opens the specified
pane

2) Adds support for a tabID to openOptionsDialog which will get passed into the
preferences dialog as a window argument. Currently, only the advanced panel is
configured to look for this argument (since the only piece of UI which needs to
open a specific tab, not just a panel is the offline UI).

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

Is it really necessary to have this menu item (files > offline > offline
settings)? We should clean up the GUI and remove this menu item, now that we
have the new pref dialog.

Comment 7

[Ivan Ičin]

(In reply to comment #6)
> Is it really necessary to have this menu item (files > offline > offline
> settings)? We should clean up the GUI and remove this menu item, now that we
> have the new pref dialog.

Probably you should file a new bug. I agree that TB interface has not gone
through such big cleaning as Firefox's one.

Comment 8

[Worcester12345]

(In reply to comment #7)
> (In reply to comment #6)
> > Is it really necessary to have this menu item (files > offline > offline
> > settings)? We should clean up the GUI and remove this menu item, now that we
> > have the new pref dialog.
> 
> Probably you should file a new bug. I agree that TB interface has not gone
> through such big cleaning as Firefox's one.

Is there a bug number for this yet?