289232 - Assertion when opening News servers

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Whenever I open a news account up, I always get the following assertion in mork.
It seems to be complaining that the .msf file for the news server doesn't exist.
 And I never see one get created. In this instance, the name of the .msf file it
is trying to open is:

+	inName	0x03389b70 "C:\Documents and Settings\mscott\Application
Data\Thunderbird\Profiles\default\e0tp69e8.slt\News\secnews.netscape.com.msf\"


morkEnv::NewError(const char * 0x03389ea8) line 404 + 19 bytes
morkFile::NewFileErrnoError(morkEnv * 0x0338b790) line 271
morkStdioFile::new_stdio_file_fault(morkEnv * 0x0338b790) line 773
morkStdioFile::OpenStdio(morkEnv * 0x0338b790, const char * 0x03389b70, const
char * 0x03849420) line 844
morkStdioFile::morkStdioFile(morkEnv * 0x0338b790, const morkUsage & {...},
nsIMdbHeap * 0x031622b4, nsIMdbHeap * 0x031622b4, const char * 0x03389b70, const
char * 0x03849420) line 798
morkStdioFile::CreateNewStdioFile(morkEnv * 0x0338b790, nsIMdbHeap * 0x031622b4,
const char * 0x03389b70) line 485 + 61 bytes
morkFile::CreateNewFile(morkEnv * 0x0338b790, nsIMdbHeap * 0x031622b4, const
char * 0x03389b70) line 190 + 17 bytes
morkFactory::CreateNewFile(morkFactory * const 0x0316225c, nsIMdbEnv *
0x0338b7bc, nsIMdbHeap * 0x031622b4, const char * 0x03389b70, nsIMdbFile * *
0x0012be54) line 251 + 17 bytes
nsMsgDatabase::OpenMDB(const char * 0x03389b70, int 1) line 1255 + 34 bytes

Comment 1

[Scott MacGregor]

i forgot to mention that the assertion is followed by the msg database
complaining that the database must be corrupt (but in reality the file just
doesn't exist)

nsMsgDatabase::GetDBFolderInfo(nsMsgDatabase * const 0x0338b4b8, nsIDBFolderInfo
* * 0x0012bfec) line 1367 + 35 bytes
nsMsgNewsFolder::GetDBFolderInfoAndDB(nsMsgNewsFolder * const 0x0312dbf0,
nsIDBFolderInfo * * 0x0012bfec, nsIMsgDatabase * * 0x0012bfe8) line 776 + 20 bytes
nsMsgDBFolder::ReadDBFolderInfo(int 1) line 534 + 67 bytes
nsMsgNewsFolder::UpdateSummaryTotals(nsMsgNewsFolder * const 0x0312dbf0, int 1)
line 852 + 19 bytes
nsMsgNewsFolder::GetDatabase(nsIMsgWindow * 0x00000000) line 396 + 21 bytes
nsMsgNewsFolder::GetDBFolderInfoAndDB(nsMsgNewsFolder * const 0x0312dbf0,
nsIDBFolderInfo * * 0x0012c0dc, nsIMsgDatabase * * 0x0012c0d4) line 771 + 17 bytes
nsMsgDBFolder::OnFlagChange(nsMsgDBFolder * const 0x0312dbf0, unsigned int 16)
line 3713 + 63 bytes
nsMsgDBFolder::ClearFlag(nsMsgDBFolder * const 0x0312dbf0, unsigned int 16) line
3691
nsMsgFolderDataSource::DoFolderAssert(nsIMsgFolder * 0x0312dbf0, nsIRDFResource
* 0x00bf9c70, nsIRDFNode * 0x00b100e0) line 2149 + 17 bytes
nsMsgFolderDataSource::Assert(nsMsgFolderDataSource * const 0x02dee280,
nsIRDFResource * 0x0312dbc8, nsIRDFResource * 0x00bf9c70, nsIRDFNode *
0x00b100e0, int 1) line 551 + 25 bytes

Comment 2

[David :Bienvenu]

Attachment: proposed fix

appending the empty string to the path is actually appending a trailing
delimiter. This check fixes that. I haven't seen any problems with the patch,
but I'll run with it for a while, and check it into the trunk when it opens.