289297 - Use nsXFormsUtils::ReportError for existing error events

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

When we throw f.x. a xforms-link-exception like this
http://lxr.mozilla.org/seamonkey/source/extensions/xforms/nsXFormsModelElement.cpp#333
we should add information to the JS console using nsXFormsUtils::ReportError()

Comment 1

[Allan Beaufour]

Attachment: Quick patch

Here's a quick patch, including a fix that stops controls from doing anything
when they do not have a parent (which triggered the same error again and again
in the cloning code.

The error messages should be refined, etc., etc. but here's a start.

Comment 2

[Doron Rosenberg (IBM)]

Allan, you forgot the properties file :)

Comment 3

[Allan Beaufour]

Attachment: Patch v/properties

(In reply to comment #2)
> Allan, you forgot the properties file :)

Properties schmoperties! :)

Here's one with the properties and does the job a bit better.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 179971 [details] [diff] [review]
Quick patch

This review is actually for
https://bugzilla.mozilla.org/attachment.cgi?id=180027

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 180027 [details] [diff] [review]
Patch v/properties

r=me

Comment 6

[Allan Beaufour]

Checked in, a=mkaply