289334 - download manager text is cut off if too long

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Ryan Foley]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050325 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050325 Camino/0.8+

When downloading, the text in the manager (i.e. "XXX of YYY (at ZZZ)") is cut
off if it is long enough and the download manager window is small enough.

Reproducible: Always

Steps to Reproduce:
1. Download a file (the larger the better)
2. Shrink the download manager as small as possible in the horizontal direction

Actual Results:  
If the text is long enough, the last few words (like KB/sec) are cut off


Expected Results:  
The text should wrap or there should be a scrollbar at the bottom

Comment 1

[Mike Pinkerton (not reading bugmail)]

no scrollbar. we should probably use ellipsis to indicate there's more text. if
the user really cares, they can make the window wider.

Comment 2

[Nick Kreeger]

Taking, shouldn't be hard to fix..

Comment 3

[Nick Kreeger]

Using source pulled and build yesterday (Aug. 2) I cant reproduce the problem.
When the window is resized, it has a minimum size for the window, thus allowing
enough room for the downloading and not cutting off any of the progress text.

Anyone else have the same?

Comment 4

[Jasper]

I guess that the reporter had a case of downloading something xxx (couple
hundred mb file) and in that case I can see how we crop the text.

In any case we should fix that, but also take care of the situation where the
file name is very long.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

You'll see truncated "status info" if you try to download an Xcode update and
have the DL Mgr window at its smallest.  I imagine people who download larger
files like ISOs and such may even see it at wider widths (I've seen it at least
once at a wider-than-smallest width, but I can't recall what I might have been
downloading).

Also, as Jasper noted, long file names, e.g. the latest Xcode preview, get
truncated (this happens for me even at my normal DL Mgr width, so even more
truncation would happen at the smallest width).

Comment 6

[Samuel Sidler (old account; do not CC)]

-> Kreeger

Comment 7

[Nick Kreeger]

Attachment: Updated ProgressView.nib

Updated ProgressView.nib. Adds "..." to a filename, downloadsize/transfer rate,
and time remaining if the window cuts off the text.

Comment 8

[Nick Kreeger]

Attachment: Updated to have truncate middle on file name, and truncate tail on the download info line

Comment 9

[Mark Mentovai]

Checking in
trunk/mozilla/camino//resources/localized/English.lproj/ProgressView.nib/keyedobjects.nib;
/cvsroot/mozilla/camino/resources/localized/English.lproj/ProgressView.nib/keyedobjects.nib,v
 <--  keyedobjects.nib
new revision: 1.3; previous revision: 1.2
done
Checking in
1.8/mozilla/camino/resources/localized/English.lproj/ProgressView.nib/keyedobjects.nib;
/cvsroot/mozilla/camino/resources/localized/English.lproj/ProgressView.nib/keyedobjects.nib,v
 <--  keyedobjects.nib
new revision: 1.2.2.1; previous revision: 1.2
done