289353 - DIVs shift and grey areas appear when scrolling page on Firefox

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect, P2)

Description

[jhp (no longer active)]

When scrolling the page listed in URL field, parts of the page shift
unnaturally, and grey areas appear.  Happens on Firefox/Mac, but not on other
platforms, and not on Camino, which means that it might point to a bug in the
carbon widget code.

Comment 1

[jhp (no longer active)]

Seems to be related to the floating DIV on the left hand side.  If I remove that
from the HTML code, then I don't see the ugliness any more.

Comment 2

[jhp (no longer active)]

Attachment: reduced testcase

Greatly reduced testcase.  To reproduce, it requires both that there be a
floating (fixed) DIV, and that the content DIV have "overflow:auto" set.

Comment 3

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050407
Firefox/1.0+

I can see this.

Comment 4

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050408
Firefox/1.0+

There is also a update/dirty/redraw problem in which sometimes when moving 
to a new URL, parts of the previous one 'show through'. I don't have a
recipe for reproduction.

Comment 5

[Ben Fowler]

(In reply to comment #4)
> Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050408
> Firefox/1.0+
> 
> ... I don't have a recipe for reproduction.

O.K. I realise that that is a little unsatisfactory. Here a receipe that works 
most of the time:

Go to a page like http://e2fsprogs.sourceforge.net/ which has links to a
'Sourceforge ummary page'.

Open that link and others in new tabs, Cmd-click for example. Go another
tab, and then to the summary page.

If my recipe worked, the the advert at the top (a javascript write( )) will
not have been painted, and will show what was on the previous tab. Refreshing,
or returning again will cause a repaint.

I suspect that this is a minor regression, or a manifestation of the problem
reported in comment 0 rather than anything major, but it may be a little
early to be certain.

Comment 6

[Benjamin Smedberg]

Can you test with a nightly trunk build? We just switch mac to use a new
eventloop model that will probably significantly hide the symptoms here.

Comment 7

[Simon Fraser [no longer active]]

I doubt the new event handling will fix this. It's a bug in the mac widget code.

Comment 8

[Benjamin Smedberg]

Do the same symptoms appear in camino (cocoa widgets)?

Comment 9

[Simon Fraser [no longer active]]

(In reply to comment #8)
> Do the same symptoms appear in camino (cocoa widgets)?

No.

Comment 10

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050702
Firefox/1.0+

Still in.

Comment 11

[philippe (part-time)]

This bug is very similar to bug 259563, which has a testcase with both
'overflow:scroll' and 'overflow:auto'.

Comment 12

[Simon Fraser [no longer active]]

*** Bug 259563 has been marked as a duplicate of this bug. ***

Comment 13

[Simon Fraser [no longer active]]

Attachment: Patch

The bug was that the code paths through nsWindow::Scroll that hit the
Invalidate() calls caused the window state (probably the update region) to be
left in a bad way for later drawing. The easiest fix for this is to make the
invalidates asynchronous.

Comment 14

[Simon Fraser [no longer active]]

Comment on attachment 189847 [details] [diff] [review]
Patch

I approve!

Comment 15

[Mike Shaver (:shaver emeritus)]

Comment on attachment 189847 [details] [diff] [review]
Patch

So do I! a=shaver

Comment 16

[Simon Fraser [no longer active]]

Checked in.

Comment 17

[Simon Fraser [no longer active]]

*** Bug 228838 has been marked as a duplicate of this bug. ***

Comment 18

[Ben Fowler]

(In reply to comment #5)
> (In reply to comment #4)
> > Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) 
> > Gecko/20050408 Firefox/1.0+
> > 
> Go to a page like http://e2fsprogs.sourceforge.net/ which has links to a
> 'Sourceforge Summary page'.
> 
> Open that link and others in new tabs, Cmd-click for example. Go another
> tab, and then to the summary page.
> 
> ...

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20050805
Firefox/1.0+

I am not seeing this problem (nor the defect reported in comment 0 ). I suspect
that this bug has many duplicates.

I will open a new report if I see it again, but it likely fixed.

Comment 19

[Simon Fraser [no longer active]]

*** Bug 292935 has been marked as a duplicate of this bug. ***