289367 - CleanResource called at wrong time

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[lvcipriani]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2


In mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp
at line 363 there is an extra semicolon:
 
        if (externalApplicationResource);
          CleanResource(mimeTypes, externalApplicationResource);
should be:
        if (externalApplicationResource)
          CleanResource(mimeTypes, externalApplicationResource);


Reproducible: Always

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 180188 [details] [diff] [review]
Patch

seems sane enough... maybe email ben to check this in. make sure its not
breaking his intended behaviour somehow.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

yeah this is fine, check in away!

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 180188 [details] [diff] [review]
Patch

one liner, typo fix

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 180188 [details] [diff] [review]
Patch

a=asa

Comment 6

[Asaf Romano (gone)]

Checking in nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v
 <--  nsSafariProfileMigrator.cpp
new revision: 1.15; previous revision: 1.14
done