289373 - Remove %FORM from editproducts.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Another deFORMication job for you.

Comment 1

[Teemu Mannermaa (:wicked)]

Attachment: Remove %FORM infestation, V1

Comment 2

[Teemu Mannermaa (:wicked)]

Attachment: Remove %FORM infestation, V1.1

Fixed handling of disallownew and confirmed variables per these comments:

<@LpSolit> $disallownew = 1 if defined $cgi->param('disallownew')
<@LpSolit> if you have disallownew=0 is the URL, then.....
<@LpSolit> wicked: use $disallownew = 1 if $cgi->param('disallownew') instead
<@LpSolit> wicked: same remark for if (!defined $cgi->param('confirmed'))

Comment 3

[Frédéric Buclin]

Comment on attachment 179990 [details] [diff] [review]
Remove %FORM infestation, V1

Clearing submitter's own review.

Comment 4

[Frédéric Buclin]

Comment on attachment 180112 [details] [diff] [review]
Remove %FORM infestation, V1.1

I changed my mind, sorry for that: we should use
defined($cgi->param('confirmed')) *but* if ($cgi->param('createseries')).

Comment 5

[Teemu Mannermaa (:wicked)]

Attachment: Remove %FORM infestation, V1.2

Comment 6

[Frédéric Buclin]

Comment on attachment 180122 [details] [diff] [review]
Remove %FORM infestation, V1.2

r=LpSolit

Comment 7

[Frédéric Buclin]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.79; previous revision: 1.78
done