Closed Bug 289373 Opened 15 years ago Closed 15 years ago

Remove %FORM from editproducts.cgi

Categories

(Bugzilla :: Bugzilla-General, defect)

2.19.2
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: LpSolit, Assigned: wicked)

References

Details

Attachments

(1 file, 2 obsolete files)

Another deFORMication job for you.
Attached patch Remove %FORM infestation, V1 (obsolete) — Splinter Review
Attachment #179990 - Flags: review?(LpSolit)
Attached patch Remove %FORM infestation, V1.1 (obsolete) — Splinter Review
Fixed handling of disallownew and confirmed variables per these comments:

<@LpSolit> $disallownew = 1 if defined $cgi->param('disallownew')
<@LpSolit> if you have disallownew=0 is the URL, then.....
<@LpSolit> wicked: use $disallownew = 1 if $cgi->param('disallownew') instead
<@LpSolit> wicked: same remark for if (!defined $cgi->param('confirmed'))
Attachment #179990 - Attachment is obsolete: true
Attachment #180112 - Flags: review?(LpSolit)
Attachment #179990 - Flags: review?(LpSolit) → review-
Comment on attachment 179990 [details] [diff] [review]
Remove %FORM infestation, V1

Clearing submitter's own review.
Attachment #179990 - Flags: review-
Comment on attachment 180112 [details] [diff] [review]
Remove %FORM infestation, V1.1

I changed my mind, sorry for that: we should use
defined($cgi->param('confirmed')) *but* if ($cgi->param('createseries')).
Attachment #180112 - Flags: review?(LpSolit) → review-
Attachment #180112 - Attachment is obsolete: true
Attachment #180122 - Flags: review?(LpSolit)
Comment on attachment 180122 [details] [diff] [review]
Remove %FORM infestation, V1.2

r=LpSolit
Attachment #180122 - Flags: review?(LpSolit) → review+
Status: NEW → ASSIGNED
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
Flags: approval? → approval+
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.79; previous revision: 1.78
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.