289385 - Links for which you've cancelled a drag should not act as clicked

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Simon Fraser [no longer active]]

There's some funky behavior with link clicking, which appears to be Mac-only.

On any page, mouse down on a link, and move the mouse a little to start a drag.
Now, while still over some part of the link, release the mouse. It will act as
if you clicked the link, and load it, which is wrong. If we've started a drag
for the link, we should never behave as if it was clicked at the end of the drag.

On Firefox, it's also possible to get the click-hold context menu to appear and
remain visible, even as we load the target page.

This appears to be Mac-only (could not reproduce on Linux).

Comment 1

[Wevah (Nate Weaver)]

I'm not sure if this is related, or not, but I've noticed that sometimes when I
click links Gecko acts as if I've just been dragging them slightly, and so I get
an outline slideback when there shouldn't be one.

(I've also been noticing some slight lag in DOM mouse events, but that's not as
serious and probably unrelated.)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Simon, are we actually generating a link click, or are we managing to drag the
link to the page itself and fail the "don't load link if it's dragged to the
same document" check?

Comment 3

[Simon Fraser [no longer active]]

The click is coming out of CheckForAndDispatchClick(), so it's thinking it's a
click (because the mouse up is over the same element as the mouse down,
according to the comment).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Do the other widget sets not send the mouseup native event if a drag has
started?  I don't get the mouseup event handler for the node I stop dragging
over firing on Linux....

Comment 5

[Wayne Mery (:wsmwk)]

does this still occur on Mac?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Seems to WFM on Mac now.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to comment #6)
> Seems to WFM on Mac now.

=> WFM then :)