289422 - Erroneous javascript Focus() function will break close of findbar

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050407 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050407 Firefox/1.0+

When implementing an errorneous focus javascript function will result in an
unclosable findbar. Green update icon is displayed (not hidden on start) when
testcase HTML file is direcly opened from local computer in a new firefox.

Reproducible: Always

Steps to Reproduce:
1. Open testcase
2. Open find toolbar (ctrl-F)
3. Try closing find toolbar

Actual Results:  
Find toolbar isn't closing, the error from the focus function is reported in
Javascript console. On direct html-file open the firefox update icon is displayed.

Expected Results:  
Find toolbar should close and mention the error in focus() in Javascript console.
No update icon when opening the testcase directly from local computer.

Comment 1

[Ger Teunis]

Attachment: Open this from local computer for 'best' results

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050406
Firefox/1.0+

Confirming

Comment 3

[Chris]

able to reproduce on windows 2000, Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8b2) Gecko/20050419 Firefox/1.0+

Error: some is not defined
Source File:
file:///C:/Documents%20and%20Settings/Administrator/Desktop/testcase.html
Line: 4

Comment 4

[Dave Townsend [:mossop]]

This appears to be almost fixed. When I open the find toolbar, clicking the
close button immediatly doesnt work, but clicking on the page then clicking
close closes it fine. Also there were no javascript errors logged.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050523
Firefox/1.0.3 ID:2005052311

Comment 5

[:Mook]

Attachment: Use a XPCNativeWrapper around _content

I tested first with a pacifica build from 1.0+_2005052317/1.8b2_2005052317 to
make sure it wasn't fixed, and that this patch does fix things.

Comment 6

[:Mook]

Attachment: use window.content.focus() instead as per mconnor over IRC

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 184377 [details] [diff] [review]
use window.content.focus() instead as per mconnor over IRC

a=shaver

Comment 8

[Asaf Romano (gone)]

Checking in findBar.js;
/cvsroot/mozilla/toolkit/components/typeaheadfind/content/findBar.js,v  <-- 
findBar.js
new revision: 1.9; previous revision: 1.8
done