289423 - Extensions should be able to provide window icons

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Benjamin Smedberg]

Extensions should be able to provide default window icons in
<extension>/chrome/icons/default just like apps can.

Comment 1

[Benjamin Smedberg]

Attachment: Load window icons from <extension>/chrome/icons/default, rev. 1

Comment 2

[Darin Fisher]

Comment on attachment 179945 [details] [diff] [review]
Load window icons from <extension>/chrome/icons/default, rev. 1

>Index: toolkit/xre/nsXREDirProvider.cpp

>   else if (!strcmp(aProperty, NS_APP_CHROME_DIR_LIST)) {
>+    // NS_APP_CHROME_DIR_LIST is only used to get default (native) icons
>+    // for OS window decoration.
>+

why is this an important thing to indicate here?  where are
the dependencies on this assumption?  it seems to me that 
this code is simply indicating where all of the "chrome"
directories live.  how is that icon specific?


r=darin

Comment 3

[Benjamin Smedberg]

Comment on attachment 179945 [details] [diff] [review]
Load window icons from <extension>/chrome/icons/default, rev. 1

Because I wanted to remind myself that *.manifest files were not read from this
location.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 179945 [details] [diff] [review]
Load window icons from <extension>/chrome/icons/default, rev. 1

a=asa

Comment 5

[Benjamin Smedberg]

Fixed on trunk.

Comment 6

[Nickolay_Ponomarev]

*** Bug 242757 has been marked as a duplicate of this bug. ***