Closed Bug 289447 Opened 20 years ago Closed 20 years ago

offline imap code leaks

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

(Keywords: memory-leak)

Attachments

(1 file)

proposed fix
6.91 KB, patch
mscott
: superreview+
brendan
: approval-aviary1.1a1+
brendan
: approval1.8b2+
Details | Diff | Splinter Review 
there are several very old memory leaks in the offline imap code - I ran purify
to try to reproduce a very elusive imap offline bug, and noticed all these
leaks. Patch upcoming.
Attached patch proposed fix — — Splinter Review 
use comptrs to fix ref-counting of offline ops. Also reworked the flag setting
operation to coalesce storing of the same flag on different messages even if
they're not contiguous.
Attachment #180088 - Flags: superreview?(mscott)
Attachment #180088 - Flags: superreview?(mscott) → superreview+
Attachment #180088 - Flags: approval-aviary1.1a?
Comment on attachment 180088 [details] [diff] [review]
proposed fix

a=me, I'm setting both flags.

/be
Attachment #180088 - Flags: approval1.8b2+
Attachment #180088 - Flags: approval-aviary1.1a?
Attachment #180088 - Flags: approval-aviary1.1a+
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: