289453 - components.initialowner is different in Bugzilla::DB::Schema than it was in the old checksetup

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Max Kanat-Alexander]

This is the last Schema inconsistency that I haven't caught before now. This is
currently why the checksetup tinderbox is orange.

Basically, before Schema, initialowner was "default NULL," and now it's "NOT
NULL." (MySQL claims that it has a "default '0'", but that's only because MySQL
is crazy and always gives NOT NULL fields a default.)

I think it makes perfect sense for initialowner to be NOT NULL, and so we should
change old installations to conform to that.

If there are any NULLs in initialowner, what should we change them to? Probably
just '0' and then sanitycheck can complain and people can deal with it, I suppose.

Comment 1

[Frédéric Buclin]

From editcomponents.cgi:

    my $initialowner = trim($cgi->param('initialowner') || '');

    if ($initialowner eq '') {
        ThrowUserError('component_need_initialowner',
                       {'name' => $component});
    }

You cannot go through, even by hacking the URL. So I don't think you could ever
have initialowner NULL, unless this check has been added only recently.

Comment 2

[Max Kanat-Alexander]

OK, so initialowner really should be NOT NULL in the DB, and we should fix
Schema appropriately.

This is a really simple change; ideally we should get it done before 2.19.3.

Comment 3

[Max Kanat-Alexander]

Attachment: Make initialowner NOT NULL

OK, this is a pretty straightforward patch. :-)

And no, we can't tie the classification_id change into this one, because we're
not actually guaranteed that this one will always run.

Comment 4

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.392; previous revision: 1.391
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.20; previous revision: 1.19
done