289461 - Give make-jars.pl the ability to use the new chrome manifests

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect, P1)

Description

[Benjamin Smedberg]

make-jars.pl needs the ability to make the new chrome manifests... I want this
for 1.1a, for l10n work Chase and I are doing... the netwerk changes are just a
small sample of what needs to happen.

Comment 1

[Benjamin Smedberg]

Attachment: Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 179973 [details] [diff] [review]
Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]

a=asa

Comment 3

[Benjamin Smedberg]

Comment on attachment 179973 [details] [diff] [review]
Add chrome manifest support to make-jars.pl, rev. 1 [make-jars.pl changes have landed]

I landed the make-jars.pl change without the jar.mn changes, because I'm
conflicting with myself in thunderbird. I will provide additional jar.mn
patches here, and wait for review in bug 289448.

Comment 4

[Benjamin Smedberg]

I backed this out because creature was orange, and it fixed the problem. I am
frankly mystified and a little worried, because this is a necessary patch to fix
bug 287262, and I could not reproduce any problems with a local seamonkey build.
Dbaron said that the tinderbox thought that some window was background-color:
transparent and that was causing interesting problems leading to stack overflow.
Can anybody reproduce that problem on a box other than creature?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diff between good and bad dist directories on creature

This is a diff between dist directories on creature with 3.74 and 3.75 of
make-jars.pl.  I unzipped all the jars, so there are no differences in the
contents of the jars (probably only timestamps, maybe compression).  The
installed-chrome.txt diffs look like the problem.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Activestate perl doesn't seem to like the fancy file mode.  Opening separately
for read and append seems to work.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

But note that when you open for read, you can't fail if the open fails, because
the file may not be there yet.

Comment 8

[Benjamin Smedberg]

Attachment: Add chrome manifest support to make-jars.pl, rev. 1.1

Don't use +>>

Comment 9

[Benjamin Smedberg]

Attachment: Add chrome manifest support to make-jars.pl, rev. 1.2

With nits from Hixie, this works on AS perl.

Comment 10

[Benjamin Smedberg]

The manifest bits of this are now checked-in also, marking FIXED.