289506 - Review, integrate dbclone on landfill

Status: RESOLVED WONTFIX

(Bugzilla :: bugzilla.org, enhancement)

Description

[Joel Peshkin]

newmysqlclone should be able to replace mysqlclone.
It permits the user to specify {version:}table instead of just the table where
the optional portion specifies which database server should be contacted.

Comment 1

[Max Kanat-Alexander]

It looks like it doesn't work if I don't specify the version (that is, it should
default to mysql3).

Also, why don't we call it "dbclone" while we're at it, and then eventually we
can put Pg support into it.

Comment 2

[Joel Peshkin]

It works for me if I don't specify the versions.

I just did 
newmysqlclone bugs_joel bugs_junk 
and it worked

dbclone sounds good btw

Comment 3

[Joel Peshkin]

I renamed it to dbclone and made it a bit more obvious what it is doing.  The
previous user output made it look underwhelming when it ran.

Comment 4

[Max Kanat-Alexander]

I'd really like it if it could have an option to drop the target database before
continuing, but only if the target database exists. This would make life in
test-checksetup a lot easier.

Also, typo and spacing:

"About to colne  bugs_214 TO  bugs_mkanat" - which should probably also let us
know when it's done.

and the "create failed" should include the system error message.

Comment 5

[Max Kanat-Alexander]

Also, it doesn't actually do any data copying if I'm using plain-old 3.23.58 and
I don't specify a : value. That is, it creates the target database, but the
target database is empty.

Comment 6

[Max Kanat-Alexander]

Don't need it; have scripts for each db.