289509 - Build changes for Thebes

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should just build Thebes when --enable-cairo is specified. I'll
attach a patch to add the right subdir to gfx/Makefile.in.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: build gfx/thebes when --enable-cairo is in effect

I guess this needs review ... but who from?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 180016 [details] [diff] [review]
build gfx/thebes when --enable-cairo is in effect

I think we should try to get this landed so that people other than me can build
thebes from the tree :-).

Of course my earlier comments were inaccurate --- this causes thebes to build
only when --with-toolkit=cairo-gtk2 or --with-toolkit=cairo-xlib are set.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 180016 [details] [diff] [review]
build gfx/thebes when --enable-cairo is in effect

build change that only affects --with-toolkit=cairo-gtk2 (i.e., nothing that's
going to ship anytime soon)

Comment 4

[chris hofmann]

Comment on attachment 180016 [details] [diff] [review]
build gfx/thebes when --enable-cairo is in effect

a=chofmann

Comment 5

[Eli Friedman]

Looks like somebody forgot to mark this fixed?