Clicking on a product when creating new dataset doesn't update Components list

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Reporting/Charting
--
major
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: mcsmurf, Assigned: gerv)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
To reproduce:
1. Go to URL
2. Click on any Product
3. Note that Components list doesn't get updated

This is a JS Problem, since JS Console spits out
Error: queryform is not defined
Source File: http://landfill.mozilla.org/bugzilla-tip/query.cgi?format=create-series
Line: 114

The form is named chartform here.
(Assignee)

Comment 1

13 years ago
Created attachment 180209 [details] [diff] [review]
Patch v.1

Thanks for the bug report :-)

I think Kiko broke this in bug 123030, when he moved the JS to a separate file
and didn't update the chart definition template to include it. It may have been
broken already by some JS rewriting too. :-((

Gerv
Attachment #180209 - Flags: review?(kiko)

Comment 2

13 years ago
Comment on attachment 180209 [details] [diff] [review]
Patch v.1

Hmmm. I guess that javascript has more callsites than immediately apparent. So
it's been broken for almost a year now? r=kiko on the change, at any rate.
Attachment #180209 - Flags: review?(kiko) → review+
(Assignee)

Updated

13 years ago
Flags: approval?
So if it's been broken for a year it probably needs to be fixed in 2.18, too.
Flags: blocking2.18.2+
Flags: approval?
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Comment 4

13 years ago
No, it works in 2.18. Maybe we've got our "broken for" estimates wrong.

Gerv
Flags: blocking2.18.2+
(Assignee)

Comment 5

13 years ago
Fixed.

Checking in template/en/default/search/search-create-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-create-series.html.tmpl,v
 <--  search-create-series.html.tmpl
new revision: 1.11; previous revision: 1.10
done

Gerv
Severity: normal → major
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
You need to log in before you can comment on or make changes to this bug.