289565 - Clicking on a product when creating new dataset doesn't update Components list

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Go to URL
2. Click on any Product
3. Note that Components list doesn't get updated

This is a JS Problem, since JS Console spits out
Error: queryform is not defined
Source File: http://landfill.mozilla.org/bugzilla-tip/query.cgi?format=create-series
Line: 114

The form is named chartform here.

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Thanks for the bug report :-)

I think Kiko broke this in bug 123030, when he moved the JS to a separate file
and didn't update the chart definition template to include it. It may have been
broken already by some JS rewriting too. :-((

Gerv

Comment 2

[Christian Reis]

Comment on attachment 180209 [details] [diff] [review]
Patch v.1

Hmmm. I guess that javascript has more callsites than immediately apparent. So
it's been broken for almost a year now? r=kiko on the change, at any rate.

Comment 3

[Dave Miller [:justdave]]

So if it's been broken for a year it probably needs to be fixed in 2.18, too.

Comment 4

[Gervase Markham [:gerv]]

No, it works in 2.18. Maybe we've got our "broken for" estimates wrong.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/search/search-create-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-create-series.html.tmpl,v
 <--  search-create-series.html.tmpl
new revision: 1.11; previous revision: 1.10
done

Gerv