289583 - allow observing all refreshes?

Status: NEW

(Core :: DOM: Navigation, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

timeless wants to observe all refreshes, as they are added as well as they are
followed.

I would suggest a function on some docshell interface:

  /**
   * Adds an observer that will get notified as new refreshes are added.
   * Only its refreshURI function will be called by this object. Exceptions from
   * the refreshURI functions will cause the refresh to be not followed.
   *
   * If the observer wants to get notified of refreshes as they are processed,
   * it should also implement nsIObserver, and will get notified with a topic
   * of "on-refresh-processed", and the subject will be the refresh target.
   *
   * Exceptions from the observe call will cause the refresh to not be followed.
   */
  void addRefreshObserver(in nsIRefreshURI aObserver);

  /**
   * Removes a previously registered observer.
   */
  void removeRefreshObserver(in nsIRefreshURI aObserver);

Opinions?

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

> and the subject will be the refresh target.

(i.e., an nsIURI)


it would be nice to also pass the docshell/nsIWebNavigation here somehow...

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't really have thoughts on the subject (though I question the entire
existence of nsIRefreshURI).

Comment 3

[timeless]

fwiw my coworkers would rather an observerservice broadcast. i think as long as
parent nsIWBP get it, we'd be ok either way.