289594 - Email Settings table is too large on a large monitor

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Max Kanat-Alexander]

I have a 1600x1200 monitor, and the "Email Settings" table is just too wide to
be easily useable, because the description of what things are is so far away
from the relevant checkbox. 

I don't think it should have "width: 100%", but it should have a "table-layout:
fixed" and then each column should have a specified size in "em".

Comment 1

[Gervase Markham [:gerv]]

Doing an alternate-row shading might also help. I'm happy with whatever as long
as you don't break any browsers :-)

Is this significantly worse than it used to be, then?

Gerv

Comment 2

[Max Kanat-Alexander]

(In reply to comment #1)
> Doing an alternate-row shading might also help. I'm happy with whatever as 
> long as you don't break any browsers :-)

  Oh, that's a good idea. :-)

> Is this significantly worse than it used to be, then?

  Actually, I think it's almost the same as it used to be, but I just noticed it
now for the first time. :-)

Comment 3

[Jacob Steenhagen]

Attachment: Patch v1

This patch moves even/odd styling of rows out of the buglist css into the
global one and uses it for this table in addition to on buglists. It also
changes the color for odd rows to be CCCCCC as F7F7F7 is so subtle it can't be
noticed in a lot of places (I was viewing my work on my laptop and couldn't
figure out what I was doing wrong until I realzied the color difference was
just too subtle). If a person desires, they can still have different colors for
this table and the buglist by specifing the table in their .css:
table.bz_emailprefs tr.odd { /* This table */ }
table.bz_buglist tr.odd { /* The buglist */ }

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 180383 [details] [diff] [review]
Patch v1

r=gerv.

Gerv

Comment 5

[Jacob Steenhagen]

Checking in skins/standard/buglist.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/buglist.css,v  <--  buglist.css
new revision: 1.9; previous revision: 1.8
done
Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.19; previous revision: 1.18
done
Checking in template/en/default/list/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v 
<--  table.html.tmpl
new revision: 1.25; previous revision: 1.24
done

Comment 6

[Max Kanat-Alexander]

It looks nice! :-) But you missed the "but NOT when" table on the Email Settings.

Also, FWIW, I think #eee is too dark, and the previous gray was quite nice. :-)
(It's only on laptops at an indirect angle that f7f7f7 won't show up right. On a
normal LCD or CRT it's quite nice.)

Comment 7

[Max Kanat-Alexander]

(In reply to comment #6)
> Also, FWIW, I think #eee is too dark,

  That is, I meant #ccc.

Comment 8

[Jacob Steenhagen]

Attachment: Bugfix v1

I'm not opposed to something in between F7F7F7 and CCCCCC, but I'd prefer that
whatever we pick works on laptop screens as well as CRTs.

Comment 9

[Max Kanat-Alexander]

Comment on attachment 180496 [details] [diff] [review]
Bugfix v1

Yeah, looks right to me.
It's just a normal diff, though, and not a diff -u. :-)

Try #eee on your laptop monitor, maybe. Also, you might want to make sure that
your laptop monitor doesn't have the brightness all the way up, or the contrast
down, because that of course can mess with the color calibration.

Comment 10

[Jacob Steenhagen]

Attachment: Bugfix v2

With the color changed to #e0e0e0 instead of #cccccc (more subtle, but still
noticable on screens like my laptop).

Comment 11

[Jacob Steenhagen]

Attachment: Bugfix v3

Put the color back to #f7f7f7. Color changes for the default install can be a
different bug :).

Comment 12

[Jacob Steenhagen]

I'm sure colors will be dealt with in the upcoming UI hackathons :).

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.12; previous revision: 1.11
done
Checking in template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.20; previous revision: 1.19
done