289595 - Can't assume there is a non-null mSchema per model

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

nsXFormsModelElement::GetTypeForControl assumes there is a valid mSchema, but we
can have models without any schemas to load.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: patch

Comment 2

[aaronr]

Comment on attachment 180093 [details] [diff] [review]
patch

please add comments around validator.GetType and validator.ValidateString to
point out that just because we don't load a schema that validation will still
work for base types.  Otherwise it isn't immediately apparent that there is
value to using a validator that hasn't had a schema loaded.

Also, if you are putting  schemaColl->GetSchema inside a if(schemaColl) test in
the first part of your patch, should do the same in the second part of your
patch.

With those nits, r=me

Comment 3

[aaronr]

Yes, you definitely need to include the ::ValidateNode part of your patch in a
if(schemaColl) test as I just got this same trap with this patch applied

Comment 4

[Doron Rosenberg (IBM)]

Attachment: fix nit

Comment 5

[Doron Rosenberg (IBM)]

checked in