289618 - variables.none.tmpl should reference globals.pl's quoteUrls function for changing bug term

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Peter Kay]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Junglescorpion/1.0.2 (All your Firefox/1.0.2 are belong to Firesomething)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Junglescorpion/1.0.2 (All your Firefox/1.0.2 are belong to Firesomething)

The template variables.none.tmpl should reference globals.pl's quoteUrls
function for changing bug term.  A comment in the template should tell the
administrator to also change the function quoteUrls(), so that a new bug term
can be linkified correctly.

Reproducible: Always

Steps to Reproduce:
1.  Change bug term (e.g., to problem).
2.  Add a comment with "problem 4".
3.  It doesn't become a link!

Comment 1

[Peter Kay]

Attachment: Patch adding comment to variables.none.tmpl

Here's a quick patch to add a comment instructing administrators to update
quoteURL() in globals.pl when they change the bug terms.

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 180105 [details] [diff] [review]
Patch adding comment to variables.none.tmpl

r=wurblzap.
globals.pl will go away in the (hopefully near) future, so quoteUrls will move
to another place soon. We'll need to change this comment then.

Comment 3

[Frédéric Buclin]

I don't check in patches from unconfirmed bugs. But as this one has already been
approved, I guess it's a valid one. ;)

I will do this checkin later today, unless someone else does it before I'm back.

Comment 4

[Frédéric Buclin]

tip:

Checking in template/en/default/global/variables.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/variables.none.tmpl,v
 <--  variables.none.tmpl
new revision: 1.3; previous revision: 1.2
done


2.18:

Checking in template/en/default/global/variables.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/variables.none.tmpl,v
 <--  variables.none.tmpl
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Comment 5

[Peter Kay]

Marc,

Should I open a new bug blocked by this one and bug 87411 with the required changes?

Comment 6

[Marc Schumann [:Wurblzap]]

(In reply to comment #5)
> Should I open a new bug blocked by this one and bug 87411 with the required
> changes?

Good idea imo. If at some time there is a more specific bug than 87411 for the
quoteUrls move, it'll be easily found and the blocking can be transferred.

Comment 7

[Jacob Steenhagen]

*** Bug 292372 has been marked as a duplicate of this bug. ***

Comment 8

[Steve Davis]

This bug does not mention "autolinkification" (the term for this feature used in
The Bugzilla Guide) or "terms.bug" (the variable in question).  Now it does;
that should help to keep dolts like me from submitting duplicates like bug
292372. :-)

Comment 9

[Olav Vitters]

*** Bug 311363 has been marked as a duplicate of this bug. ***