289633 - wrong type for nsKeyCode::KeyCodeIsModifier

Status: RESOLVED INVALID

(Core Graveyard :: Widget: Xlib, defect)

Description

[timeless]

XButtonEvent(3X11)        XLIB FUNCTIONS       XButtonEvent(3X11)
       typedef struct {
            int type;                /* KeyPress or KeyRelease */
            unsigned long serial;    /* # of last request processed by server */
            Bool send_event;         /* true if this came from a SendEvent reque
st */
            Display *display;        /* Display the event was read from */
            Window window;           /* ``event'' window it is reported relative
 to */
            Window root;             /* root window that the event occurred on *
/
            Window subwindow;        /* child window */
            Time time;               /* milliseconds */
            int x, y;                /* pointer x, y coordinates in event window
 */
            int x_root, y_root;      /* coordinates relative to root */
            unsigned int state;      /* key or button mask */
            unsigned int keycode;    /* detail */
            Bool same_screen;        /* same screen flag */
       } XKeyEvent;

KeyCode is 8bits, which is problematic since we're comparing it against numbers
that are more than 8bits.

Comment 1

[timeless]

Attachment: fix declaration to match data

Comment 2

[timeless]

Comment on attachment 180115 [details] [diff] [review]
fix declaration to match data

new patch coming after testing

Comment 3

[JP Rosevear [:jpr]]

Xlib is not supported nor is it a target.  Xlib widget code has also been deleted from the tree.