289640 - Remove unused preference security.ui.enable

Status: VERIFIED FIXED

Description

[Daniel Cater]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050408 Firefox/1.0+

security.ui.enable is NEVER used in any code anywhere.

Here is the only place where it appears: 
http://lxr.mozilla.org./mozilla/source/netwerk/base/public/security-prefs.js#47

And here is the CVS Log for that checkin: 
http://bonsai.mozilla.org./cvslog.cgi?file=mozilla/netwerk/base/public/security-prefs.js#1.4

And here is what was checked in: 
http://bonsai.mozilla.org./cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=security-prefs.js&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/public&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4

Reproducible: Always

Steps to Reproduce:

1. View the above 3 URIs, and also about:config
2. Search LXR for where the preference is used.

Actual Results:

about:config shows the preference (defaults to true.)
LXR shows nowhere that uses the preference.

Expected Results:

Either:

a) Preference does something.

Or

b) Prefence doesn't exist.

Comment 1

[Daniel Cater]

Created attachment 207893 [details] [diff] [review]
Remove the preference

Doug, is there any need for this preference you checked in years ago?

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 207893 [details] [diff] [review]
Remove the preference

i do not think it is needed.

Comment 3

[Daniel Cater]

Thanks, can someone check this in for me please?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/netwerk/base/public/security-prefs.js; new revision: 1.13;

Comment 5

[Worcester12345]

Is this also in branch? If it is indeed trivial, is the impact also trivial? I know streamlining both code and code size are always important around here. Thanks.