289650 - nsIWebBrowserPersist should inherit from nsICancelable

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, enhancement, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I want to make exthandler and webbrowserpersist expose a common interface for
cancelling downloads, so that nsITransfer::init can take an nsICancelable
instead of an nsIWebBrowserPersist, and to remove its observer attribute.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 180138 [details] [diff] [review]
patch

I'd like to have this in 1.8b2 - it only implements an additional interface on
nsWebBrowserPersist and should thus be low-risk.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, I meant to comment on why I left cancelSave() on this interface... that's
for compatibility with existing javascript code using nsIWBP.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 180138 [details] [diff] [review]
patch

oops. this patch misses a change...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 180171 [details] [diff] [review]
patch v2

a=asa

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in embedding/browser/webBrowser/nsWebBrowser.cpp;
/cvsroot/mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp,v  <-- 
nsWebBrowser.cpp
new revision: 1.151; previous revision: 1.150
done
Checking in embedding/browser/webBrowser/nsWebBrowser.h;
/cvsroot/mozilla/embedding/browser/webBrowser/nsWebBrowser.h,v  <--  nsWebBrowser.h
new revision: 1.48; previous revision: 1.47
done
Checking in embedding/components/webbrowserpersist/public/nsIWebBrowserPersist.idl;
/cvsroot/mozilla/embedding/components/webbrowserpersist/public/nsIWebBrowserPersist.idl,v
 <--  nsIWebBrowserPersist.idl
new revision: 1.17; previous revision: 1.16
done
Checking in embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v
 <--  nsWebBrowserPersist.cpp
new revision: 1.108; previous revision: 1.107
done
Checking in embedding/components/webbrowserpersist/src/nsWebBrowserPersist.h;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.h,v
 <--  nsWebBrowserPersist.hnew revision: 1.30; previous revision: 1.29
done