289677 - mtext color not respected

Status: VERIFIED FIXED

(Core :: MathML, defect)

Description

[Martin Mokrejs]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050408
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050408

The word "Theorem 1" in the testcase should appear in red, instead of black as
in mozilla now.

Reproducible: Always

Comment 1

[Bernd]

thats more mathml

Comment 2

[rbs]

mathcolor='#f05' works fine (try it at:
http://www.mozilla.org/projects/mathml/demo/tester.html).
Looks like an oversight somewhere in the code for 'color'.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

I have no idea why "mathcolor" worked.... "fontsize" didn't work, nor did
"color" (unless "mathcolor" happened to be also set).

In any case, part of the problem is that the @namespace rule was never being
inserted into the sheet (inserting rules via DOM methods into an incomplete
sheet throws).	Once that was fixed, things started to Just Work.

Comment 4

[rbs]

Comment on attachment 183670 [details] [diff] [review]
Patch

r+sr=rbs

=============
The next bit of of code assumed that the '@namespace' was insterted (and thus
was sitting in position 0), and so was inserting 'color' (and others from
MathML1) to position '1'.  That fails if @namespace  failed earlier and
position 0 was unoccupied...

===============
    if (k >= 0) {
      // insert the rule (note: when the sheet already has @namespace and
      // friends, insert after them, e.g., at the end, otherwise it won't work)
      // For MathML 2, insert at the end to give it precedence
      PRInt32 pos = (map->compatibility == kMathMLversion2) ? count : 1;
      PRUint32 index;
      domSheet->InsertRule(cssRule, pos, &index);
      ++ruleCount;
    }
=================

[PS: friends of '@namespace' include '@charset', and since these have to be
first for those DOM things to work, the offset '1' has to be kept in sync if
somebody changes that code to add more @-rules. Missing Get@RuleCount() here...
Looks like JavaScript'ers are going to be bitten by this kind of things.]

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183670 [details] [diff] [review]
Patch

Requesting 1.8b2 approval.  This only affects MathML and is quite safe.

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183670 [details] [diff] [review]
Patch

a=shaver.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

"Theorem 1" does indeed appear in red in build 2005-05-16-06, Windows XP
Seamonkey trunk, when loading
http://www.w3.org/Math/testsuite/testsuite/Presentation/TokenElements/mtext/mtextAtoken3.xml

Verified FIXED