289693 - EditSettings page changes name from the link in the footer

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Colin Ogilvie [:cso]]

In the Admin Footer, editsettings.cgi is referred to as "User Settings" but on
the page its called "Edit Global Settings"

Personal opinion is that this is a bad thing, because its not consistent. Adding
Myk to CC in case he has an opinion as the UI lead and owner.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Yes, it is a bad thing.  This should be called "Default Preferences," since we
call user settings "preferences," and these are their defaults.  Also, we should
remove the word "settings" from the names of the tabs on the user preferences
page, since it is redundant and inconsistent with the name of the page itself.

Comment 2

[Gabriel Sales de Oliveira]

Attachment: Template changes

A small template fix.

Comment 3

[Frédéric Buclin]

Comment on attachment 186359 [details] [diff] [review]
Template changes

>Index: template/en/default/admin/settings/updated.html.tmpl

>@@ -19,9 +19,9 @@
>    title = "Settings Updated"
>  %]

Replace 'Settings' by 'Preferences'

Moreover, you forgot to update the footer too, see
global/useful-links.html.tmpl line 78.

And 'settings' should be replaced my 'preference' everywhere in the text.

Comment 4

[Gabriel Sales de Oliveira]

Attachment: s/setting/preference

As you wish s/setting/preference . :)

Comment 5

[Frédéric Buclin]

Comment on attachment 186471 [details] [diff] [review]
s/setting/preference

>Index: template/en/default/account/prefs/prefs.html.tmpl

>-[% tabs = [ { name => "account", description => "Account settings", 
>+[% tabs = [ { name => "account", description => "Account", 
>               saveable => "1" },
>-            { name => "settings", description => "General Settings", 
>+            { name => "settings", description => "General", 
>               saveable => "1" }, 
>-            { name => "email", description => "Email settings", 
>+            { name => "email", description => "Email", 
>               saveable => "1" },
>             { name => "saved-searches", description => "Saved searches", 
>               saveable => "1" },

This won't work. These tab descriptions are used in the text displayed when you
update your preferences:

 The changes to your general have been saved.

Of course, it should say "general preferences". To fix that, add "preferences"
in the text itself, see line 91.

Comment 6

[Frédéric Buclin]

Comment on attachment 186471 [details] [diff] [review]
s/setting/preference

I said to ask myk for review on an updated patch fixing the bug I mentioned,
not this one.

Comment 7

[Gabriel Sales de Oliveira]

Attachment: bug fixed

Bug fix.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 186486 [details] [diff] [review]
bug fixed

Looks good, r=myk

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Low risk polish; r=myk for check in during 2.20 freeze.

Comment 10

[Frédéric Buclin]

Checking in template/en/default/account/prefs/prefs.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/prefs.html.tmpl,v
 <--  prefs.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/admin/settings/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/settings/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/settings/updated.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/settings/updated.html.tmpl,v
 <--  updated.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.38; previous revision: 1.37
done