289722 - week view: double click on event box does not edit event [trunk]

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050406 Firefox/1.0.3
Build Identifier: trunk

Regression:

Double clicking on an event box in week view brings up an empty event dialog.
Works in other views.

Reproducible: Always

Steps to Reproduce:
1. Double click on an event box in week view
2.
3.

Actual Results:  
Event dialog appears but with empty fields

Expected Results:  
Event dialog appears with fields from clicked event.

JavaScript Console

Error: calendarEvent has no properties
Source File: chrome://calendar/content/weekView.js
Line: 603

Warning: reference to undefined property eventBox.calEvent
Source File: chrome://calendar/content/calendar.js
Line: 473

Comment 1

[gekacheka]

Attachment: calendar.js: replace eventBox.calEvent with eventBox.event

(patch -l -p 2 -i file.patch)

Problem was using
  eventBox.calEvent
when should be
  eventBox.event

("event" is ambiguous, because there is both a click event and a calendar event
involved in these methods.  In the future maybe rename the eventBox.event to
itemBox.item, since it will sometimes be a todo item.)

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

checked in