289729 - fix for 3 "uninitialized value" messages

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

1) process_bug.cgi: Use of uninitialized value in string ne at Bugzilla/Flag.pm
line 283.

if ($requestee_email ne $flag->{'requestee'}->{'email'})


2) userprefs.cgi: Use of uninitialized value in numeric eq (==) at
/var/www/html/cvsbugzilla/userprefs.cgi line 235.

if (1 == $cgi->param("email-$rel-$event"))


Patch coming....

Comment 1

[Frédéric Buclin]

3) process_bug.cgi: Use of uninitialized value in string ne at Bugzilla/Flag.pm
line 572.

my $requestee_changed = ($status eq "?" &&
                         $flag->{'type'}->{'is_requesteeble'} &&
                         $old_requestee ne $requestee_email);

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

This patch mainly checks that variables are defined before using them.

Note also that I replaced $flag->{'requestee'}->{'email'} by
$flag->{'requestee'}->login as this is the way User::match_field() and
Flag::modifiy() work.

Comment 3

[Frédéric Buclin]

Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.74; previous revision: 1.73
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.36; previous revision: 1.35
done