289744 - Location bar has no focus after creating new window

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[TGOS]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050409
Firefox/1.0+

Just open a new window. Focus is not on location bar. It used to be there for
all previous Firefox versions. Then there was a bug, preventing it from being
there and throwing a JS exception. It got fixed. Now the bug is back agian (I
couldn't find it anymore, if you can, please post the number here), but this
time there is no exception, just the focus is not where it should be.

Maybe important: I have type-as-you-find search enabled.

Comment 1

[TGOS]

Just downloaded nightlies going backwards to find out when exactly this broke
again. In

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050404
Firefox/1.0+

it is still working, so it broken exactly with next nightly build.

I'm on my way to find out which checkin could have broke this.

Comment 2

[TGOS]

Might have been this checkin, as it's focus related:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/content/events/src&command=DIFF_FRAMESET&file=nsEventStateManager.cpp&rev1=1.561&rev2=1.562&root=/cvsroot

But might also be this one, as it is about opening new windows:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser.js&rev1=1.406&rev2=1.407&root=/cvsroot

The rest seems not related, but I'm not a Mozilla expert, so don't rely on me ;)
I'm just trying to be helpful :)

This bug is definitely serious, so I'd say we should set blocking 1.1

Comment 3

[Peter van der Woude [:Peter6]]

setting the flag help ;-)

-> ?1.1

Comment 4

[TGOS]

Okay, has been fixed again; at least it works again in 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050412
Firefox/1.0+