289746 - Day view splits long events at midnight Amsterdam time. [trunk]

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.7) Gecko/20050406 Firefox/1.0.3
Build Identifier: trunk

Day view splits long events into two boxes at midnight Amsterdam time.

Reproducible: Always

Steps to Reproduce:
1. Set OS timezone to something with an offset different from Amsterdam time.
2. Create a long event that cross midnight Amsterdam time.
3.

Actual Results:  
The event will be shown as two boxes, and the title will appear twice, once at
its normal time, and once at midnight Amsterdam time.

Expected Results:  
The event is shown as one box.

Looks like cause is at calendarWindow createEventBox:
http://lxr.mozilla.org/seamonkey/source/calendar/resources/content/calendarWindow.js#721

Comment 1

[gekacheka]

Attachment: calendarWindow.js patch: comment out amsterdam timezone

(patch -l -p 2 -i file.patch)

This patch comments out the hardcoded Amsterdam timezone.
CreateEventBox will take the default branch so it works based on current OS
timezone.

Comment 2

[gekacheka]

Attachment: dayView.js patch: fix startDate.jsDate.getHours() to startDate.hour (jsDate in different timezone)

(patch -l -p 2 -i file.patch)

The first patch causes date view to display events with the wrong timezone
offset.

The problem is that startDate is created with UTC timezone at the
createEventBox default/unknown timezone branch, so getting the
starDate.jsDate.getHours() will be different from startDate.hour in most
timezones.  (JavaScript Date is always relative to the current OS timezone.)

This patch corrects the problem by fixing the reference to
startDate.jsDate.getHours() to be startDate.hour.

Comment 3

[gekacheka]

Attachment: calendarWindow createEventBox patch to create fewer jsDates

(patch -l -p 2 -i file.patch)

Efficiency patch: create each .jsDate just once, rather than many times.
It looks like each reference of the property creates and initilizes a new Date
object.
http://lxr.mozilla.org/seamonkey/source/calendar/base/src/calDateTime.cpp#457

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 180224 [details] [diff] [review]
calendarWindow.js patch: comment out amsterdam timezone

I should have done it like this in the first place. checked in.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 180225 [details] [diff] [review]
dayView.js patch: fix startDate.jsDate.getHours() to startDate.hour (jsDate in different timezone)

checked in this patch.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

all patched checked in.