289750 - File-Open File... in MailNews does nothing

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Open MailNews
2. File->Open File...
3. Nothing happens

This regressed between 2005-04-05-06 and 2005-04-06-06, one checkin from Bug
288366 looks suspicious, CCing folks.

Comment 1

[Ian Neal]

Attachment: Do not mix patch v0.1

This patch:
* Swaps command back to observes where there is also an oncommand

Alternative approach is to make sure the relevant cmd_xxx calls what is in the
oncommand so that the oncommand can be removed.

Comment 2

[[e-mail]]

Comment on attachment 180236 [details] [diff] [review]
Do not mix patch v0.1

>-        command="cmd_openFileMessage"
>+        observes="cmd_openFileMessage"
As there's no such command, there's no point observing it.

>-      <menuitem id="menu_undo" label="&undoDefaultCmd.label;" accesskey="&undoDefaultCmd.accesskey;" key="key_undo" command="cmd_undo" oncommand="Undo()"/>
>-      <menuitem id="menu_redo" label="&redoDefaultCmd.label;" accesskey="&redoDefaultCmd.accesskey;" key="key_redo" command="cmd_redo" oncommand="Redo()"/>
>+      <menuitem id="menu_undo" label="&undoDefaultCmd.label;" accesskey="&undoDefaultCmd.accesskey;" key="key_undo" observes="cmd_undo" oncommand="Undo()"/>
>+      <menuitem id="menu_redo" label="&redoDefaultCmd.label;" accesskey="&redoDefaultCmd.accesskey;" key="key_redo" observes="cmd_redo" oncommand="Redo()"/>
Stop me if I'm wrong, but doesn't utilityOverlay.xul already add the label,
key, accesskey and command to these elements? In which case whatever we do here
will have no effect and we'll need to fix this in a separate bug.

>               oncommand="CreateFilter(document.popupNode)"
>-              command="cmd_createFilterFromPopup"/>  
>+              observes="cmd_createFilterFromPopup"/>  
>                   oncommand="CreateFilter(document.popupNode)"
>-                  command="cmd_createFilterFromPopup"/>  
>+                  observes="cmd_createFilterFromPopup"/>  
>               oncommand="CreateFilter(document.popupNode)"
>-              command="cmd_createFilterFromPopup"/>  
>+              observes="cmd_createFilterFromPopup"/>  
Yes, this oncommand should be centralised on the command element.

Comment 3

[Ian Neal]

Attachment: Revised patch v0.1a

Changes since v0.1a
* Centralises the oncommand for "cmd_createFilterFromPopup"
* Removes unused observer "cmd_openFileMessage"
* Removes changes to undo/redo in v0.1

Comment 4

[Ian Neal]

Attachment: Updated patch v0.1b

Changes since v0.1a
* Removed unused parts of menuitems for menu_undo and menu_redo
* Removed unused accesskeys from messenger.dtd
* Corrected accesskeys in utilityOverlay.dtd

Comment 5

[[e-mail]]

Comment on attachment 180281 [details] [diff] [review]
Updated patch v0.1b

function Undo() and function Redo() aren't used any more are they?

Comment 6

[Ian Neal]

Attachment: Tweaked NoDo patch v0.1c (Checked in)

Changes since v0.1b
* Removed Undo/Redo functions from commandglue.js - as suggested by Neil

Carrying forward r=

Comment 7

[Ian Neal]

Comment on attachment 180294 [details] [diff] [review]
Tweaked NoDo patch v0.1c (Checked in)

Requesting a=
Fairly low risk patch that fixes a regression on the trunk from landing of bug
288366

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 180294 [details] [diff] [review]
Tweaked NoDo patch v0.1c (Checked in)

a=asa

Comment 9

[Ian Neal]

Comment on attachment 180294 [details] [diff] [review]
Tweaked NoDo patch v0.1c (Checked in)

Checking in xpfe/communicator/resources/locale/en-US/utilityOverlay.dtd;
/cvsroot/mozilla/xpfe/communicator/resources/locale/en-US/utilityOverlay.dtd,v 
<--  utilityOverlay.dtd
new revision: 1.29; previous revision: 1.28
done
Checking in mailnews/base/resources/locale/en-US/messenger.dtd;
/cvsroot/mozilla/mailnews/base/resources/locale/en-US/messenger.dtd,v  <-- 
messenger.dtd
new revision: 1.198; previous revision: 1.197
done
Checking in mailnews/base/resources/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.xul,v  <-- 
mailWindowOverlay.xul
new revision: 1.291; previous revision: 1.290
done
Checking in mailnews/base/resources/content/mail3PaneWindowCommands.js;
/cvsroot/mozilla/mailnews/base/resources/content/mail3PaneWindowCommands.js,v 
<--  mail3PaneWindowCommands.js
new revision: 1.143; previous revision: 1.142
done
Checking in mailnews/base/resources/content/mail3PaneWindowVertLayout.xul;
/cvsroot/mozilla/mailnews/base/resources/content/mail3PaneWindowVertLayout.xul,
v  <--	mail3PaneWindowVertLayout.xul
new revision: 1.105; previous revision: 1.104
done
Checking in mailnews/base/resources/content/messenger.xul;
/cvsroot/mozilla/mailnews/base/resources/content/messenger.xul,v  <-- 
messenger.xul
new revision: 1.257; previous revision: 1.256
done
Checking in mailnews/base/resources/content/messageWindow.js;
/cvsroot/mozilla/mailnews/base/resources/content/messageWindow.js,v  <-- 
messageWindow.js
new revision: 1.104; previous revision: 1.103
done
Checking in mailnews/base/resources/content/messageWindow.xul;
/cvsroot/mozilla/mailnews/base/resources/content/messageWindow.xul,v  <-- 
messageWindow.xul
new revision: 1.80; previous revision: 1.79
done
Checking in mailnews/base/resources/content/commandglue.js;
/cvsroot/mozilla/mailnews/base/resources/content/commandglue.js,v  <-- 
commandglue.js
new revision: 1.255; previous revision: 1.254
done

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-04-18-05 on Windows XP Seamonkey trunk.